Re: Review Request 121079: Fix building dolphin tests on MSVC
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121079/ --- (Updated Abril 19, 2015, 3:13 p.m.) Status -- This change has been discarded. Review request for KDE Base Apps, KDE Frameworks and kdewin. Repository: kde-baseapps Description --- MSVC complains about missing symbols from their respective moc files on linking step. Diffs - dolphin/src/tests/CMakeLists.txt 60f6517 Diff: https://git.reviewboard.kde.org/r/121079/diff/ Testing --- It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121079: Fix building dolphin tests on MSVC
On Fev. 12, 2015, 10:54 p.m., Albert Astals Cid wrote: Patch doesn't apply, please rebase superseded by RR https://git.reviewboard.kde.org/r/123270/, discarding this one. - Andrius da Costa --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121079/#review75951 --- On Nov. 8, 2014, 10:26 p.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121079/ --- (Updated Nov. 8, 2014, 10:26 p.m.) Review request for KDE Base Apps, KDE Frameworks and kdewin. Repository: kde-baseapps Description --- MSVC complains about missing symbols from their respective moc files on linking step. Diffs - dolphin/src/tests/CMakeLists.txt 60f6517 Diff: https://git.reviewboard.kde.org/r/121079/diff/ Testing --- It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121079: Fix building dolphin tests on MSVC
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121079/#review75951 --- Patch doesn't apply, please rebase - Albert Astals Cid On nov. 8, 2014, 10:26 p.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121079/ --- (Updated nov. 8, 2014, 10:26 p.m.) Review request for KDE Base Apps, KDE Frameworks and kdewin. Repository: kde-baseapps Description --- MSVC complains about missing symbols from their respective moc files on linking step. Diffs - dolphin/src/tests/CMakeLists.txt 60f6517 Diff: https://git.reviewboard.kde.org/r/121079/diff/ Testing --- It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121079: Fix building dolphin tests on MSVC
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121079/#review72341 --- Ship it! Ship It! - David Faure On Nov. 8, 2014, 10:26 p.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121079/ --- (Updated Nov. 8, 2014, 10:26 p.m.) Review request for KDE Base Apps, KDE Frameworks and kdewin. Repository: kde-baseapps Description --- MSVC complains about missing symbols from their respective moc files on linking step. Diffs - dolphin/src/tests/CMakeLists.txt 60f6517 Diff: https://git.reviewboard.kde.org/r/121079/diff/ Testing --- It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 121079: Fix building dolphin tests on MSVC
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121079/ --- Review request for KDE Base Apps, KDE Frameworks and kdewin. Repository: kde-baseapps Description --- MSVC complains about missing symbols from their respective moc files on linking step. Diffs - dolphin/src/tests/CMakeLists.txt 60f6517 Diff: https://git.reviewboard.kde.org/r/121079/diff/ Testing --- It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
