Re: Review Request 121145: A button which appears on the side of a splitter handle and allows easy collapsing of the widget on the opposite side

2014-11-18 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121145/#review70575 --- Ship it! Ship It! - Christoph Feck On Nov. 17, 2014, 4:48

Re: Review Request 121145: A button which appears on the side of a splitter handle and allows easy collapsing of the widget on the opposite side

2014-11-18 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121145/ --- (Updated Nov. 18, 2014, 11:23 a.m.) Status -- This change has been

Re: Review Request 121145: A button which appears on the side of a splitter handle and allows easy collapsing of the widget on the opposite side

2014-11-17 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121145/ --- (Updated Nov. 17, 2014, 3:39 p.m.) Review request for KDE Frameworks,

Re: Review Request 121145: A button which appears on the side of a splitter handle and allows easy collapsing of the widget on the opposite side

2014-11-17 Thread Laurent Montel
On nov. 17, 2014, 3:24 après-midi, Christoph Feck wrote: src/ksplittercollapserbutton.cpp, line 276 https://git.reviewboard.kde.org/r/121145/diff/3/?file=328890#file328890line276 Please pass at least a QStyleOption to pixelMetric(). For some styles, the metric depends on the font

Re: Review Request 121145: A button which appears on the side of a splitter handle and allows easy collapsing of the widget on the opposite side

2014-11-17 Thread Christoph Feck
On Nov. 17, 2014, 3:24 p.m., Christoph Feck wrote: src/ksplittercollapserbutton.cpp, line 276 https://git.reviewboard.kde.org/r/121145/diff/3/?file=328890#file328890line276 Please pass at least a QStyleOption to pixelMetric(). For some styles, the metric depends on the font size,

Re: Review Request 121145: A button which appears on the side of a splitter handle and allows easy collapsing of the widget on the opposite side

2014-11-17 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121145/ --- (Updated nov. 17, 2014, 4:48 après-midi) Review request for KDE