Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

2016-05-31 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121218/ --- (Updated May 31, 2016, 2:44 p.m.) Status -- This change has been mar

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

2016-05-22 Thread David Faure
> On April 5, 2015, 2:26 p.m., David Faure wrote: > > Well, +1 for the idea. But I wonder what the apidox will look like, the > > macro+template probably don't make it work. > > > > Also missing @since 5.10. > > > > Ship it from me once the apidox issue is resolved. > > Gleb Popov wrote: >

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

2016-05-22 Thread Gleb Popov
> On April 5, 2015, 5:26 p.m., David Faure wrote: > > Well, +1 for the idea. But I wonder what the apidox will look like, the > > macro+template probably don't make it work. > > > > Also missing @since 5.10. > > > > Ship it from me once the apidox issue is resolved. > > Gleb Popov wrote: >

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

2016-05-22 Thread David Faure
> On April 5, 2015, 2:26 p.m., David Faure wrote: > > Well, +1 for the idea. But I wonder what the apidox will look like, the > > macro+template probably don't make it work. > > > > Also missing @since 5.10. > > > > Ship it from me once the apidox issue is resolved. > > Gleb Popov wrote: >

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

2016-05-22 Thread Alex Richardson
> On April 5, 2015, 3:26 p.m., David Faure wrote: > > Well, +1 for the idea. But I wonder what the apidox will look like, the > > macro+template probably don't make it work. > > > > Also missing @since 5.10. > > > > Ship it from me once the apidox issue is resolved. > > Gleb Popov wrote: >

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

2016-05-21 Thread David Faure
> On April 5, 2015, 2:26 p.m., David Faure wrote: > > Well, +1 for the idea. But I wonder what the apidox will look like, the > > macro+template probably don't make it work. > > > > Also missing @since 5.10. > > > > Ship it from me once the apidox issue is resolved. > > Gleb Popov wrote: >

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

2016-05-20 Thread Gleb Popov
> On April 5, 2015, 5:26 p.m., David Faure wrote: > > Well, +1 for the idea. But I wonder what the apidox will look like, the > > macro+template probably don't make it work. > > > > Also missing @since 5.10. > > > > Ship it from me once the apidox issue is resolved. What apidox issue is being

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

2015-04-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121218/#review78527 --- Well, +1 for the idea. But I wonder what the apidox will look

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

2015-02-26 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121218/#review76681 --- Ping? - Alex Richardson On Dez. 24, 2014, 1:23 nachm., Alex

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

2014-12-24 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121218/ --- (Updated Dez. 24, 2014, 1:23 nachm.) Review request for KDE Frameworks, D

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

2014-12-20 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121218/#review72345 --- MSVC2012 doesn't support default template parameters on functi

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

2014-12-01 Thread Milian Wolff
> On Nov. 30, 2014, 2:29 p.m., Milian Wolff wrote: > > src/kstandardaction.cpp, line 153 > > > > > > is the call to `setCheckable` not required anymore? b/c that is > > otherwise missing on the new patch now, no

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

2014-11-30 Thread Alexander Richardson
> On Nov. 30, 2014, 2:29 nachm., Milian Wolff wrote: > > src/kstandardaction.cpp, line 153 > > > > > > is the call to `setCheckable` not required anymore? b/c that is > > otherwise missing on the new patch now,

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

2014-11-30 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121218/ --- (Updated Nov. 30, 2014, 2:29 p.m.) Review request for KDE Frameworks, Dav

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

2014-11-30 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121218/#review71120 --- src/kstandardaction.cpp

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

2014-11-30 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121218/#review71115 --- Add a kf5 reviewer otherwise nobody will review it. By default

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

2014-11-28 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121218/ --- (Updated Nov. 28, 2014, 8:02 nachm.) Review request for KDE Frameworks.

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

2014-11-28 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121218/ --- (Updated Nov. 28, 2014, 7:51 nachm.) Review request for KDE Frameworks.

Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

2014-11-23 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121218/ --- Review request for KDE Frameworks. Repository: kconfigwidgets Descripti