Re: Review Request 121379: kwidgetsaddons/kpageview.cpp: remove top-right icon

2014-12-12 Thread Albert Astals Cid
El Divendres, 12 de desembre de 2014, a les 15:31:03, Gregor Mi va escriure: > > On Dec. 12, 2014, 11:18 a.m., Hugo Pereira Da Costa wrote: > > > Seriously ! this is abusing review board. Silent consent ? > > > At the very least one should deprecate the part of the API that allow > > > apps to set

Re: Review Request 121379: kwidgetsaddons/kpageview.cpp: remove top-right icon

2014-12-12 Thread Gregor Mi
> On Dec. 12, 2014, 11:18 a.m., Hugo Pereira Da Costa wrote: > > Seriously ! this is abusing review board. Silent consent ? > > At the very least one should deprecate the part of the API that allow apps > > to set the icon, since it is not honoured. > > I would honestly recommand to revert this

Re: Review Request 121379: kwidgetsaddons/kpageview.cpp: remove top-right icon

2014-12-12 Thread Christoph Feck
> On Dec. 12, 2014, 11:18 a.m., Hugo Pereira Da Costa wrote: > > Seriously ! this is abusing review board. Silent consent ? > > At the very least one should deprecate the part of the API that allow apps > > to set the icon, since it is not honoured. > > I would honestly recommand to revert this

Re: Review Request 121379: kwidgetsaddons/kpageview.cpp: remove top-right icon

2014-12-12 Thread Gregor Mi
> On Dec. 12, 2014, 11:18 a.m., Hugo Pereira Da Costa wrote: > > Seriously ! this is abusing review board. Silent consent ? > > At the very least one should deprecate the part of the API that allow apps > > to set the icon, since it is not honoured. > > I would honestly recommand to revert this

Re: Review Request 121379: kwidgetsaddons/kpageview.cpp: remove top-right icon

2014-12-12 Thread Hugo Pereira Da Costa
> On Dec. 12, 2014, 11:18 a.m., Hugo Pereira Da Costa wrote: > > Seriously ! this is abusing review board. Silent consent ? > > At the very least one should deprecate the part of the API that allow apps > > to set the icon, since it is not honoured. > > I would honestly recommand to revert this

Re: Review Request 121379: kwidgetsaddons/kpageview.cpp: remove top-right icon

2014-12-12 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121379/#review71849 --- Seriously ! this is abusing review board. Silent consent ? At

Re: Review Request 121379: kwidgetsaddons/kpageview.cpp: remove top-right icon

2014-12-12 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121379/ --- (Updated Dec. 12, 2014, 11:04 a.m.) Status -- This change has been m

Re: Review Request 121379: kwidgetsaddons/kpageview.cpp: remove top-right icon

2014-12-09 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121379/#review71632 --- Ship it! Very good, maybe we can assume a silent consent. On

Re: Review Request 121379: kwidgetsaddons/kpageview.cpp: remove top-right icon

2014-12-07 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121379/#review71519 --- As background: I was the one who added this icon in KDE4 times

Review Request 121379: kwidgetsaddons/kpageview.cpp: remove top-right icon

2014-12-07 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121379/ --- Review request for KDE Frameworks, Christoph Feck and Dominik Haumann. Re