---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121390/
---
(Updated March 1, 2015, 10:02 p.m.)
Status
--
This change has been d
> On Dec. 8, 2014, 3:07 p.m., Martin Gräßlin wrote:
> > this is wrong - please have a look at various frameworks on how to do it
> > properly. In the end it should be:
> > #if HAVE_X11
> > // x11 specific stuff
> > #endif
> >
> > obviously it also needs a runtime check:
> > if (QX11Info::isPlat
> On 十二月 8, 2014, 9:07 a.m., Martin Gräßlin wrote:
> > this is wrong - please have a look at various frameworks on how to do it
> > properly. In the end it should be:
> > #if HAVE_X11
> > // x11 specific stuff
> > #endif
> >
> > obviously it also needs a runtime check:
> > if (QX11Info::isPlatf
> On 十二月 8, 2014, 9:07 a.m., Martin Gräßlin wrote:
> > this is wrong - please have a look at various frameworks on how to do it
> > properly. In the end it should be:
> > #if HAVE_X11
> > // x11 specific stuff
> > #endif
> >
> > obviously it also needs a runtime check:
> > if (QX11Info::isPlatf
> On Dec. 8, 2014, 3:07 p.m., Martin Gräßlin wrote:
> > this is wrong - please have a look at various frameworks on how to do it
> > properly. In the end it should be:
> > #if HAVE_X11
> > // x11 specific stuff
> > #endif
> >
> > obviously it also needs a runtime check:
> > if (QX11Info::isPlat
> On Dec. 8, 2014, 3:07 p.m., Martin Gräßlin wrote:
> > this is wrong - please have a look at various frameworks on how to do it
> > properly. In the end it should be:
> > #if HAVE_X11
> > // x11 specific stuff
> > #endif
> >
> > obviously it also needs a runtime check:
> > if (QX11Info::isPlat
> On 十二月 8, 2014, 9:07 a.m., Martin Gräßlin wrote:
> > this is wrong - please have a look at various frameworks on how to do it
> > properly. In the end it should be:
> > #if HAVE_X11
> > // x11 specific stuff
> > #endif
> >
> > obviously it also needs a runtime check:
> > if (QX11Info::isPlatf
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121390/
---
(Updated Dec. 8, 2014, 10:59 p.m.)
Review request for KDE Frameworks, Qt
> On Dec. 8, 2014, 3:07 p.m., Martin Gräßlin wrote:
> > this is wrong - please have a look at various frameworks on how to do it
> > properly. In the end it should be:
> > #if HAVE_X11
> > // x11 specific stuff
> > #endif
> >
> > obviously it also needs a runtime check:
> > if (QX11Info::isPlat
> On Dez. 8, 2014, 2:07 nachm., Martin Gräßlin wrote:
> > this is wrong - please have a look at various frameworks on how to do it
> > properly. In the end it should be:
> > #if HAVE_X11
> > // x11 specific stuff
> > #endif
> >
> > obviously it also needs a runtime check:
> > if (QX11Info::isPl
> On Dec. 8, 2014, 3:07 p.m., Martin Gräßlin wrote:
> > this is wrong - please have a look at various frameworks on how to do it
> > properly. In the end it should be:
> > #if HAVE_X11
> > // x11 specific stuff
> > #endif
> >
> > obviously it also needs a runtime check:
> > if (QX11Info::isPlat
> On Dec. 8, 2014, 3:07 p.m., Martin Gräßlin wrote:
> > this is wrong - please have a look at various frameworks on how to do it
> > properly. In the end it should be:
> > #if HAVE_X11
> > // x11 specific stuff
> > #endif
> >
> > obviously it also needs a runtime check:
> > if (QX11Info::isPlat
> On Dec. 8, 2014, 3:07 p.m., Martin Gräßlin wrote:
> > this is wrong - please have a look at various frameworks on how to do it
> > properly. In the end it should be:
> > #if HAVE_X11
> > // x11 specific stuff
> > #endif
> >
> > obviously it also needs a runtime check:
> > if (QX11Info::isPlat
> On Dec. 8, 2014, 3:07 p.m., Martin Gräßlin wrote:
> > this is wrong - please have a look at various frameworks on how to do it
> > properly. In the end it should be:
> > #if HAVE_X11
> > // x11 specific stuff
> > #endif
> >
> > obviously it also needs a runtime check:
> > if (QX11Info::isPlat
> On Dec. 8, 2014, 3:07 p.m., Martin Gräßlin wrote:
> > this is wrong - please have a look at various frameworks on how to do it
> > properly. In the end it should be:
> > #if HAVE_X11
> > // x11 specific stuff
> > #endif
> >
> > obviously it also needs a runtime check:
> > if (QX11Info::isPlat
> On Dez. 8, 2014, 2:07 nachm., Martin Gräßlin wrote:
> > this is wrong - please have a look at various frameworks on how to do it
> > properly. In the end it should be:
> > #if HAVE_X11
> > // x11 specific stuff
> > #endif
> >
> > obviously it also needs a runtime check:
> > if (QX11Info::isPl
> On Dec. 8, 2014, 3:07 p.m., Martin Gräßlin wrote:
> > this is wrong - please have a look at various frameworks on how to do it
> > properly. In the end it should be:
> > #if HAVE_X11
> > // x11 specific stuff
> > #endif
> >
> > obviously it also needs a runtime check:
> > if (QX11Info::isPlat
> On Dec. 8, 2014, 3:07 p.m., Martin Gräßlin wrote:
> > this is wrong - please have a look at various frameworks on how to do it
> > properly. In the end it should be:
> > #if HAVE_X11
> > // x11 specific stuff
> > #endif
> >
> > obviously it also needs a runtime check:
> > if (QX11Info::isPlat
> On Dec. 8, 2014, 3:07 p.m., Martin Gräßlin wrote:
> > this is wrong - please have a look at various frameworks on how to do it
> > properly. In the end it should be:
> > #if HAVE_X11
> > // x11 specific stuff
> > #endif
> >
> > obviously it also needs a runtime check:
> > if (QX11Info::isPlat
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121390/#review71553
---
this is wrong - please have a look at various frameworks on ho
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121390/
---
(Updated Dec. 8, 2014, 2:38 p.m.)
Review request for KDE Frameworks, Qt K
21 matches
Mail list logo
