Re: Review Request 121838: Fix KCoreConfigSkeleton when toggling a value with saves in between

2015-01-06 Thread David Faure
On Jan. 4, 2015, 5:02 p.m., David Faure wrote: This undoes 4846b50aea0bc2262238963a85ab3556c22412e4 (https://git.reviewboard.kde.org/r/117010/), basically. However looking back at the discussions with Alexander Richardson, this might be only a revert of the part that went further

Re: Review Request 121838: Fix KCoreConfigSkeleton when toggling a value with saves in between

2015-01-06 Thread Albert Astals Cid
On gen. 4, 2015, 5:02 p.m., David Faure wrote: This undoes 4846b50aea0bc2262238963a85ab3556c22412e4 (https://git.reviewboard.kde.org/r/117010/), basically. However looking back at the discussions with Alexander Richardson, this might be only a revert of the part that went further

Re: Review Request 121838: Fix KCoreConfigSkeleton when toggling a value with saves in between

2015-01-06 Thread David Faure
On Jan. 4, 2015, 5:02 p.m., David Faure wrote: This undoes 4846b50aea0bc2262238963a85ab3556c22412e4 (https://git.reviewboard.kde.org/r/117010/), basically. However looking back at the discussions with Alexander Richardson, this might be only a revert of the part that went further

Re: Review Request 121838: Fix KCoreConfigSkeleton when toggling a value with saves in between

2015-01-06 Thread Albert Astals Cid
On gen. 6, 2015, 11:55 p.m., Aleix Pol Gonzalez wrote: CMakeLists.txt, line 5 https://git.reviewboard.kde.org/r/121838/diff/2/?file=338706#file338706line5 Unrelated. And why? Because not all of us are bleeding edge that have everything up to date and requiring ecm 1.6 here is not

Re: Review Request 121838: Fix KCoreConfigSkeleton when toggling a value with saves in between

2015-01-06 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121838/#review73314 --- Ship it! Thanks, LGTM. If possible, could you please split

Re: Review Request 121838: Fix KCoreConfigSkeleton when toggling a value with saves in between

2015-01-06 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121838/ --- (Updated Jan. 6, 2015, 11:55 p.m.) Status -- This change has been

Re: Review Request 121838: Fix KCoreConfigSkeleton when toggling a value with saves in between

2015-01-06 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121838/#review73316 --- CMakeLists.txt

Re: Review Request 121838: Fix KCoreConfigSkeleton when toggling a value with saves in between

2015-01-06 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121838/ --- (Updated gen. 6, 2015, 10:41 p.m.) Review request for KDE Frameworks and

Re: Review Request 121838: Fix KCoreConfigSkeleton when toggling a value with saves in between

2015-01-05 Thread Matthew Dawson
On Jan. 4, 2015, 12:02 p.m., David Faure wrote: This undoes 4846b50aea0bc2262238963a85ab3556c22412e4 (https://git.reviewboard.kde.org/r/117010/), basically. However looking back at the discussions with Alexander Richardson, this might be only a revert of the part that went further

Re: Review Request 121838: Fix KCoreConfigSkeleton when toggling a value with saves in between

2015-01-05 Thread Matthew Dawson
On Jan. 4, 2015, 12:02 p.m., David Faure wrote: This undoes 4846b50aea0bc2262238963a85ab3556c22412e4 (https://git.reviewboard.kde.org/r/117010/), basically. However looking back at the discussions with Alexander Richardson, this might be only a revert of the part that went further

Re: Review Request 121838: Fix KCoreConfigSkeleton when toggling a value with saves in between

2015-01-05 Thread Albert Astals Cid
On gen. 4, 2015, 5:02 p.m., David Faure wrote: This undoes 4846b50aea0bc2262238963a85ab3556c22412e4 (https://git.reviewboard.kde.org/r/117010/), basically. However looking back at the discussions with Alexander Richardson, this might be only a revert of the part that went further