Re: Review Request 122481: Fix use of environ for OS X

2015-02-09 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122481/ --- (Updated Feb. 9, 2015, 3:17 p.m.) Status -- This change has been mar

Re: Review Request 122481: Fix use of environ for OS X

2015-02-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122481/#review75661 --- Ship it! Nice! - David Faure On Feb. 9, 2015, 3:24 a.m., J

Re: Review Request 122481: Fix use of environ for OS X

2015-02-08 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122481/ --- (Updated Feb. 8, 2015, 8:24 p.m.) Review request for KDE Frameworks, Davi

Re: Review Request 122481: Fix use of environ for OS X

2015-02-08 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122481/#review75645 --- Why not port to `http://doc.qt.io/qt-5/qprocessenvironment.ht

Re: Review Request 122481: Fix use of environ for OS X

2015-02-08 Thread René J . V . Bertin
> On Feb. 8, 2015, 5:44 p.m., René J.V. Bertin wrote: > > src/widgets/kurlcompletion.cpp, line 836 > > > > > > Qt5 has Q_OS_OSX to target OS X rather than a Mac OS (which according > > to Qt includes iOS). > >

Re: Review Request 122481: Fix use of environ for OS X

2015-02-08 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122481/ --- (Updated Feb. 8, 2015, 3:06 p.m.) Review request for KDE Frameworks, Davi

Re: Review Request 122481: Fix use of environ for OS X

2015-02-08 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122481/#review75613 --- src/widgets/kurlcompletion.cpp

Review Request 122481: Fix use of environ for OS X

2015-02-08 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122481/ --- Review request for KDE Software on Mac OS X, KDE Frameworks, David Faure, M