Re: Review Request 122498: Register with dbus to wake up KRun, and unregister then
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122498/ --- (Updated March 10, 2015, 11:59 a.m.) Status -- This change has been marked as submitted. Review request for Kate and KDE Frameworks. Changes --- Submitted with commit 5207e49a84145e21060f3b5beff302a437cfeccd by Martin Klapetek on behalf of Liu Zhe to branch Applications/15.04. Repository: kate Description --- This is the patch from bug 339094. As it seemes there's no response/activity to that, I just put it here for proper review (and will commit on behalf of Liu Zhe obviously) as this is really annoying bug. Following is the description by Liu: Documentation of KToolInvocation (called by KRun when click a file in dolphin) said Multi means Always start a new service, wait until the service has registered with D-Bus. But when the second text file is opened, kate just starts a QApplication and waits, without registering with DBus. In KDE 4, the second instance of kate launchs an empty KApplication to do this job, but the author said it's too bad to register a service. Maybe we can register to make KService happy and unregister at once. Another problem is that the kate icon will jump quite a few seconds after clicking the second file. I thought the reason was KStartupInfo::appStarted() not called as it requires Q_WS_X11 macro, which is not defined in Qt 5. But the bug still exists after I fixed this. Diffs - kate/src/kateapp.cpp 4c26f33 kate/src/main.cpp 8852754 Diff: https://git.reviewboard.kde.org/r/122498/diff/ Testing --- Hrvoje confirmed in the bug report that this indeed fixes the issue. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122498: Register with dbus to wake up KRun, and unregister then
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122498/ --- (Updated Feb. 16, 2015, 9:08 p.m.) Review request for Kate and KDE Frameworks. Changes --- Fix the HAVE_X11 usage. I've removed it altogether as KStartupInfo has implementations for all platforms (mostly stubs but still) and Kate depends on relatively new KF (5.6). I didn't go for the X-DBUS-StartupType=None fix as I really don't know if Kate or any other part of the app execution process requires it for anything or not. Repository: kate Description --- This is the patch from bug 339094. As it seemes there's no response/activity to that, I just put it here for proper review (and will commit on behalf of Liu Zhe obviously) as this is really annoying bug. Following is the description by Liu: Documentation of KToolInvocation (called by KRun when click a file in dolphin) said Multi means Always start a new service, wait until the service has registered with D-Bus. But when the second text file is opened, kate just starts a QApplication and waits, without registering with DBus. In KDE 4, the second instance of kate launchs an empty KApplication to do this job, but the author said it's too bad to register a service. Maybe we can register to make KService happy and unregister at once. Another problem is that the kate icon will jump quite a few seconds after clicking the second file. I thought the reason was KStartupInfo::appStarted() not called as it requires Q_WS_X11 macro, which is not defined in Qt 5. But the bug still exists after I fixed this. Diffs (updated) - kate/src/kateapp.cpp 4c26f33 kate/src/main.cpp 8852754 Diff: https://git.reviewboard.kde.org/r/122498/diff/ Testing --- Hrvoje confirmed in the bug report that this indeed fixes the issue. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122498: Register with dbus to wake up KRun, and unregister then
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122498/#review76057 --- Ship it! I am still no sure, if that is the best way to go, but if it works around the current nasty bug, please commit and close the bug! Thanks for taking care of the patch. - Christoph Cullmann On Feb. 9, 2015, 11:04 a.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122498/ --- (Updated Feb. 9, 2015, 11:04 a.m.) Review request for Kate and KDE Frameworks. Repository: kate Description --- This is the patch from bug 339094. As it seemes there's no response/activity to that, I just put it here for proper review (and will commit on behalf of Liu Zhe obviously) as this is really annoying bug. Following is the description by Liu: Documentation of KToolInvocation (called by KRun when click a file in dolphin) said Multi means Always start a new service, wait until the service has registered with D-Bus. But when the second text file is opened, kate just starts a QApplication and waits, without registering with DBus. In KDE 4, the second instance of kate launchs an empty KApplication to do this job, but the author said it's too bad to register a service. Maybe we can register to make KService happy and unregister at once. Another problem is that the kate icon will jump quite a few seconds after clicking the second file. I thought the reason was KStartupInfo::appStarted() not called as it requires Q_WS_X11 macro, which is not defined in Qt 5. But the bug still exists after I fixed this. Diffs - CMakeLists.txt 408f502 config.h.cmake d15b78e kate/src/kateapp.cpp 4c26f33 kate/src/main.cpp 8852754 Diff: https://git.reviewboard.kde.org/r/122498/diff/ Testing --- Hrvoje confirmed in the bug report that this indeed fixes the issue. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122498: Register with dbus to wake up KRun, and unregister then
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122498/#review76088 --- kate/src/kateapp.cpp https://git.reviewboard.kde.org/r/122498/#comment52504 This will always be true, it should be #if Same with the other checks - Alex Richardson On Feb. 9, 2015, 11:04 vorm., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122498/ --- (Updated Feb. 9, 2015, 11:04 vorm.) Review request for Kate and KDE Frameworks. Repository: kate Description --- This is the patch from bug 339094. As it seemes there's no response/activity to that, I just put it here for proper review (and will commit on behalf of Liu Zhe obviously) as this is really annoying bug. Following is the description by Liu: Documentation of KToolInvocation (called by KRun when click a file in dolphin) said Multi means Always start a new service, wait until the service has registered with D-Bus. But when the second text file is opened, kate just starts a QApplication and waits, without registering with DBus. In KDE 4, the second instance of kate launchs an empty KApplication to do this job, but the author said it's too bad to register a service. Maybe we can register to make KService happy and unregister at once. Another problem is that the kate icon will jump quite a few seconds after clicking the second file. I thought the reason was KStartupInfo::appStarted() not called as it requires Q_WS_X11 macro, which is not defined in Qt 5. But the bug still exists after I fixed this. Diffs - CMakeLists.txt 408f502 config.h.cmake d15b78e kate/src/kateapp.cpp 4c26f33 kate/src/main.cpp 8852754 Diff: https://git.reviewboard.kde.org/r/122498/diff/ Testing --- Hrvoje confirmed in the bug report that this indeed fixes the issue. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122498: Register with dbus to wake up KRun, and unregister then
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122498/#review76017 --- 1) AFAICS KStartupInfo exists on all platforms nowadays, even if it doesn't do much on other platforms. So the whole HAVE_X11 is unnecesary. 2) the alternative is to change kate.desktop to X-DBUS-StartupType=None. Then klauncher won't wait until DBus registration. I guess the reason for waiting for DBus registrations are only: * making it possible to then make dbus calls to the app; but that's not really needed for multi, nor for unique these days with dbus autostart * having a way to report sorry, it crashed - David Faure On Feb. 9, 2015, 11:04 a.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122498/ --- (Updated Feb. 9, 2015, 11:04 a.m.) Review request for Kate and KDE Frameworks. Repository: kate Description --- This is the patch from bug 339094. As it seemes there's no response/activity to that, I just put it here for proper review (and will commit on behalf of Liu Zhe obviously) as this is really annoying bug. Following is the description by Liu: Documentation of KToolInvocation (called by KRun when click a file in dolphin) said Multi means Always start a new service, wait until the service has registered with D-Bus. But when the second text file is opened, kate just starts a QApplication and waits, without registering with DBus. In KDE 4, the second instance of kate launchs an empty KApplication to do this job, but the author said it's too bad to register a service. Maybe we can register to make KService happy and unregister at once. Another problem is that the kate icon will jump quite a few seconds after clicking the second file. I thought the reason was KStartupInfo::appStarted() not called as it requires Q_WS_X11 macro, which is not defined in Qt 5. But the bug still exists after I fixed this. Diffs - CMakeLists.txt 408f502 config.h.cmake d15b78e kate/src/kateapp.cpp 4c26f33 kate/src/main.cpp 8852754 Diff: https://git.reviewboard.kde.org/r/122498/diff/ Testing --- Hrvoje confirmed in the bug report that this indeed fixes the issue. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 122498: Register with dbus to wake up KRun, and unregister then
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122498/ --- Review request for Kate and KDE Frameworks. Repository: kate Description --- This is the patch from bug 339094. As it seemes there's no response/activity to that, I just put it here for proper review (and will commit on behalf of Liu Zhe obviously) as this is really annoying bug. Following is the description by Liu: Documentation of KToolInvocation (called by KRun when click a file in dolphin) said Multi means Always start a new service, wait until the service has registered with D-Bus. But when the second text file is opened, kate just starts a QApplication and waits, without registering with DBus. In KDE 4, the second instance of kate launchs an empty KApplication to do this job, but the author said it's too bad to register a service. Maybe we can register to make KService happy and unregister at once. Another problem is that the kate icon will jump quite a few seconds after clicking the second file. I thought the reason was KStartupInfo::appStarted() not called as it requires Q_WS_X11 macro, which is not defined in Qt 5. But the bug still exists after I fixed this. Diffs - CMakeLists.txt 408f502 config.h.cmake d15b78e kate/src/kateapp.cpp 4c26f33 kate/src/main.cpp 8852754 Diff: https://git.reviewboard.kde.org/r/122498/diff/ Testing --- Hrvoje confirmed in the bug report that this indeed fixes the issue. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
