Re: Review Request 122910: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122910/ --- (Updated April 15, 2015, 9:21 p.m.) Status -- This change has been m

Re: Review Request 122910: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122910/ --- (Updated April 15, 2015, 9:11 p.m.) Review request for KDE Frameworks and

Re: Review Request 122910: Introduce KMoreTools

> On April 15, 2015, 2:39 p.m., Jeremy Whiting wrote: > > Ship It! > > Gregor Mi wrote: > > As KMoreTools is going to be part of KNewStuff it should be using > KNEWSTUFF_EXPORT not KSERVICE_EXPORT. > > The install dir now looks like this: > http://wstaw.org/m/2015/04/15/plasma-des

Re: Review Request 122910: Introduce KMoreTools

> On April 15, 2015, 8:39 p.m., Jeremy Whiting wrote: > > Ship It! > As KMoreTools is going to be part of KNewStuff it should be using > KNEWSTUFF_EXPORT not KSERVICE_EXPORT. The install dir now looks like this: http://wstaw.org/m/2015/04/15/plasma-desktopVd2099.png I wonder if this ok to ha

Re: Review Request 122910: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122910/#review78995 --- Ship it! Ship It! - Jeremy Whiting On April 15, 2015, 2:24

Re: Review Request 122910: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122910/ --- (Updated April 15, 2015, 8:24 p.m.) Review request for KDE Frameworks and

Re: Review Request 122910: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122910/#review78941 --- As KMoreTools is going to be part of KNewStuff it should be us

Re: Review Request 122910: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122910/ --- (Updated April 12, 2015, 11:54 a.m.) Review request for KDE Frameworks an

Re: Review Request 122910: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122910/ --- (Updated April 12, 2015, 11:17 a.m.) Review request for KDE Frameworks an

Re: Review Request 122910: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122910/ --- (Updated April 2, 2015, 4:48 p.m.) Review request for KDE Frameworks and

Re: Review Request 122910: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122910/ --- (Updated March 22, 2015, 12:37 p.m.) Review request for KDE Frameworks an

Re: Review Request 122910: Introduce KMoreTools

> On March 15, 2015, 10:31 a.m., Dominik Haumann wrote: > > src/kmoretools/kmoretools.h, line 394 > > > > > > Do we need the kmt-prefix? Why not just > > KMoreToolsService * service(); > > Gregor Mi wrote: >

Re: Review Request 122910: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122910/ --- (Updated March 22, 2015, 7:41 a.m.) Review request for KDE Frameworks and

Re: Review Request 122910: Introduce KMoreTools

> On March 15, 2015, 10:31 a.m., Dominik Haumann wrote: > > src/kmoretools/kmoretools.h, line 287 > > > > > > @return, never @returns. > > > > Further, can you be mor verbose? > > > > @return Re

Re: Review Request 122910: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122910/ --- (Updated March 15, 2015, 5:18 p.m.) Review request for KDE Frameworks and

Re: Review Request 122910: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122910/ --- (Updated March 15, 2015, 5:07 p.m.) Review request for KDE Frameworks and

Re: Review Request 122910: Introduce KMoreTools

> On March 15, 2015, 10:31 a.m., Dominik Haumann wrote: > > src/kmoretools/kmoretools.h, line 287 > > > > > > @return, never @returns. > > > > Further, can you be mor verbose? > > > > @return Re

Re: Review Request 122910: Introduce KMoreTools

> On March 15, 2015, 10:31 a.m., Dominik Haumann wrote: > > src/kmoretools/kmoretools.h, line 36 > > > > > > Proper doxygen would look like this: The first sentence is always the > > "brief" documentation. > >

Re: Review Request 122910: Introduce KMoreTools

> On March 15, 2015, 10:31 a.m., Dominik Haumann wrote: > > src/kmoretools/kmoretools.h, line 394 > > > > > > Do we need the kmt-prefix? Why not just > > KMoreToolsService * service(); I am not completely th

Re: Review Request 122910: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122910/#review77511 --- src/kmoretools/kmoretools.cpp

Re: Review Request 122910: Introduce KMoreTools

> On March 15, 2015, 10:31 a.m., Dominik Haumann wrote: > > src/kmoretools/kmoretools.h, line 412 > > > > > > Qt API never returns a this pointer when settings some properties. > > > > While not explicit

Re: Review Request 122910: Introduce KMoreTools

> On March 15, 2015, 10:31 a.m., Dominik Haumann wrote: > > src/kmoretools/kmoretools.h, line 412 > > > > > > Qt API never returns a this pointer when settings some properties. > > > > While not explicit

Re: Review Request 122910: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122910/#review77502 --- I don't think that the patch in it's current form is ok to com

Re: Review Request 122910: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122910/ --- (Updated March 11, 2015, 11:06 p.m.) Review request for KDE Frameworks, E

Review Request 122910: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122910/ --- Review request for KDE Frameworks, Emmanuel Pescosta and Jeremy Whiting.