Re: Review Request 123794: Implement find previous in KTextEdit.

2015-05-14 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123794/#review80365 --- Ship it! Nice! cache the options, switch direction,

Review Request 123794: Implement find previous in KTextEdit.

2015-05-14 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123794/ --- Review request for KDE Frameworks and Laurent Montel. Repository:

Re: Review Request 123794: Implement find previous in KTextEdit.

2015-05-14 Thread David Faure
On May 14, 2015, 10:08 p.m., Jeremy Whiting wrote: Nice! cache the options, switch direction, findNext, then unswitch directions. Looks good. Yup, no trick - it's the way KFind's docu recommends doing it. [ok I did write that docu, ages ago...] - David

Re: Review Request 123794: Implement find previous in KTextEdit.

2015-05-14 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123794/ --- (Updated May 14, 2015, 11 p.m.) Status -- This change has been