Re: Review Request 124212: kwindowsystem: Change source file layout

2015-07-07 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124212/ --- (Updated July 7, 2015, 11:31 a.m.) Status -- This change has been

Re: Review Request 124212: kwindowsystem: Change source file layout

2015-07-01 Thread Aleix Pol Gonzalez
On June 30, 2015, 4:59 p.m., Aleix Pol Gonzalez wrote: In general, I like it. Maybe now that we're putting the files in separate directories, we can drop the _mac postfixes? Martin Gräßlin wrote: I like the idea, but that won't be possible for all cases. E.g. with

Re: Review Request 124212: kwindowsystem: Change source file layout

2015-07-01 Thread Aleix Pol Gonzalez
On June 30, 2015, 4:59 p.m., Aleix Pol Gonzalez wrote: In general, I like it. Maybe now that we're putting the files in separate directories, we can drop the _mac postfixes? Martin Gräßlin wrote: I like the idea, but that won't be possible for all cases. E.g. with

Re: Review Request 124212: kwindowsystem: Change source file layout

2015-07-01 Thread Martin Gräßlin
On June 30, 2015, 4:59 p.m., Aleix Pol Gonzalez wrote: In general, I like it. Maybe now that we're putting the files in separate directories, we can drop the _mac postfixes? Martin Gräßlin wrote: I like the idea, but that won't be possible for all cases. E.g. with

Re: Review Request 124212: kwindowsystem: Change source file layout

2015-07-01 Thread Martin Gräßlin
On June 30, 2015, 4:59 p.m., Aleix Pol Gonzalez wrote: In general, I like it. Maybe now that we're putting the files in separate directories, we can drop the _mac postfixes? Martin Gräßlin wrote: I like the idea, but that won't be possible for all cases. E.g. with

Re: Review Request 124212: kwindowsystem: Change source file layout

2015-07-01 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124212/ --- (Updated July 1, 2015, 8:20 a.m.) Review request for KDE Frameworks.

Re: Review Request 124212: kwindowsystem: Change source file layout

2015-06-30 Thread Kai Uwe Broulik
On Juni 30, 2015, 8:30 vorm., Kai Uwe Broulik wrote: Doesn't build on OSX: [ 24%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/platforms/osx/kkeyserver_mac.cpp.o [ 27%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/KF5WindowSystem_automoc.cpp.o In file

Re: Review Request 124212: kwindowsystem: Change source file layout

2015-06-30 Thread Martin Gräßlin
On June 30, 2015, 10:30 a.m., Kai Uwe Broulik wrote: Doesn't build on OSX: [ 24%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/platforms/osx/kkeyserver_mac.cpp.o [ 27%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/KF5WindowSystem_automoc.cpp.o In file

Re: Review Request 124212: kwindowsystem: Change source file layout

2015-06-30 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124212/#review81880 --- Doesn't build on OSX: [ 24%] Building CXX object

Re: Review Request 124212: kwindowsystem: Change source file layout

2015-06-30 Thread Kai Uwe Broulik
On Juni 30, 2015, 8:30 vorm., Kai Uwe Broulik wrote: Doesn't build on OSX: [ 24%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/platforms/osx/kkeyserver_mac.cpp.o [ 27%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/KF5WindowSystem_automoc.cpp.o In file

Re: Review Request 124212: kwindowsystem: Change source file layout

2015-06-30 Thread Martin Gräßlin
On June 30, 2015, 10:30 a.m., Kai Uwe Broulik wrote: Doesn't build on OSX: [ 24%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/platforms/osx/kkeyserver_mac.cpp.o [ 27%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/KF5WindowSystem_automoc.cpp.o In file

Re: Review Request 124212: kwindowsystem: Change source file layout

2015-06-30 Thread Martin Gräßlin
On Juni 30, 2015, 4:59 nachm., Aleix Pol Gonzalez wrote: In general, I like it. Maybe now that we're putting the files in separate directories, we can drop the _mac postfixes? I like the idea, but that won't be possible for all cases. E.g. with kkeyserver_foo it's still needed as

Re: Review Request 124212: kwindowsystem: Change source file layout

2015-06-30 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124212/#review81902 --- In general, I like it. Maybe now that we're putting the

Re: Review Request 124212: kwindowsystem: Change source file layout

2015-06-30 Thread Aleix Pol Gonzalez
On June 30, 2015, 4:59 p.m., Aleix Pol Gonzalez wrote: In general, I like it. Maybe now that we're putting the files in separate directories, we can drop the _mac postfixes? Martin Gräßlin wrote: I like the idea, but that won't be possible for all cases. E.g. with

Review Request 124212: kwindowsystem: Change source file layout

2015-06-30 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124212/ --- Review request for KDE Frameworks. Repository: kwindowsystem