---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124282/#review82306
---
Ship it!
Three minor things left, this is looking really
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124282/#review82323
---
Ship it!
Ship It!
- Jesse Jaara
On heinä 10, 2015, 11:15
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124282/
---
(Updated heinä 10, 2015, 11:15 ap)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124282/
---
(Updated July 10, 2015, 12:11 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124282/
---
(Updated heinä 10, 2015, 10:41 ap)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124282/
---
(Updated heinä 10, 2015, 11:12 ap)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124282/#review82252
---
some style nitpicks from my side, but it looks very good
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124282/
---
(Updated heinä 9, 2015, 10:41 ip)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124282/
---
(Updated heinä 8, 2015, 5:10 ip)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124282/#review82192
---
src/plugins/voikko/voikkoclient.cpp (line 28)
On July 7, 2015, 7:07 p.m., Martin Tobias Holmedahl Sandsmark wrote:
src/plugins/voikko/voikkodict.cpp, line 125
https://git.reviewboard.kde.org/r/124282/diff/3/?file=383592#file383592line125
if (replacements.contains(word)) {
suggestions.append(word);
}
On July 7, 2015, 9:07 p.m., Martin Tobias Holmedahl Sandsmark wrote:
src/plugins/voikko/voikkoclient.cpp, line 32
https://git.reviewboard.kde.org/r/124282/diff/3/?file=383588#file383588line32
I prefer to error out early («if (!dictionaries) return;»), less
indentation and state
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124282/
---
(Updated heinä 7, 2015, 2 ip)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124282/#review82174
---
src/plugins/voikko/voikkoclient.h (line 37)
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124282/
---
Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124282/
---
(Updated heinä 7, 2015, 2:44 ip)
Review request for KDE Frameworks and
On heinä 7, 2015, 2:11 ip, Aleix Pol Gonzalez wrote:
src/plugins/voikko/voikkodict.cpp, line 261
https://git.reviewboard.kde.org/r/124282/diff/1/?file=383564#file383564line261
qCDebug(SONNET_VOIKKO) Loaded words.size() replacements
from the user dictionary.;
Same
17 matches
Mail list logo
