Re: Review Request 124876: KSycoca: check timestamps and run kbuildsycoca if needed. No kded needed anymore.

2015-08-30 Thread David Faure
On Aug. 30, 2015, 2:07 p.m., Vishesh Handa wrote: src/sycoca/ksycoca.cpp, line 644 https://git.reviewboard.kde.org/r/124876/diff/1/?file=397207#file397207line644 Does the added `(void)` disable some kind of warning? Yes it's the standard way of expressing I'm discarding the return

Re: Review Request 124876: KSycoca: check timestamps and run kbuildsycoca if needed. No kded needed anymore.

2015-08-30 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124876/#review84583 --- src/sycoca/ksycoca.cpp (line 574)

Re: Review Request 124876: KSycoca: check timestamps and run kbuildsycoca if needed. No kded needed anymore.

2015-08-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124876/ --- (Updated Aug. 28, 2015, 9:41 a.m.) Status -- This change has been

Re: Review Request 124876: KSycoca: check timestamps and run kbuildsycoca if needed. No kded needed anymore.

2015-08-24 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124876/#review84272 --- More context: ``` [5748] klauncher not running... launching

Re: Review Request 124876: KSycoca: check timestamps and run kbuildsycoca if needed. No kded needed anymore.

2015-08-24 Thread Kevin Funk
On Aug. 24, 2015, 12:15 p.m., Kevin Funk wrote: More context: ``` [5748] klauncher not running... launching kdeinit [6344] kf5.kinit.klauncher: LAUNCHER_OK [2892] Could not find drkonqi at Z:/kderoot/bin/drkonqi [2892] QObject::connect: No such signal

Re: Review Request 124876: KSycoca: check timestamps and run kbuildsycoca if needed. No kded needed anymore.

2015-08-24 Thread Kevin Funk
On Aug. 24, 2015, 12:07 p.m., Kevin Funk wrote: Still runs kbuildsycoca5 for me(?) ``` [3796] kf5.kservice.sycoca: Trying to open ksycoca from C:/Users/kfunk/AppData/Local/cache/ksycoca5 [3796] checking file timestamps [3796] timestamps check ok [3796] Emitting

Re: Review Request 124876: KSycoca: check timestamps and run kbuildsycoca if needed. No kded needed anymore.

2015-08-24 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124876/#review84269 --- Still runs kbuildsycoca5 for me(?) ``` [3796]

Re: Review Request 124876: KSycoca: check timestamps and run kbuildsycoca if needed. No kded needed anymore.

2015-08-24 Thread David Faure
On Aug. 24, 2015, 12:07 p.m., Kevin Funk wrote: Still runs kbuildsycoca5 for me(?) ``` [3796] kf5.kservice.sycoca: Trying to open ksycoca from C:/Users/kfunk/AppData/Local/cache/ksycoca5 [3796] checking file timestamps [3796] timestamps check ok [3796] Emitting

Review Request 124876: KSycoca: check timestamps and run kbuildsycoca if needed. No kded needed anymore.

2015-08-22 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124876/ --- Review request for KDE Frameworks, Boudewijn Rempt and Vishesh Handa.