Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-31 Thread Hanspeter Niederstrasser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124892/ --- (Updated Aug. 31, 2015, 9:10 p.m.) Status -- This change has been di

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-27 Thread Harald Sitter
> On Aug. 25, 2015, 2:22 p.m., René J.V. Bertin wrote: > > > When built as SHARED as in the current code, libdraganddropplugin.dylib > > > gets installed to $PREFIX/share/qt5/qml/org/kde/draganddrop, but is given > > > an OS X install_name of $PREFIX/lib/libdraganddropplugin.dylib. This > > >

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-26 Thread Marco Martin
> On Aug. 25, 2015, 2:22 p.m., René J.V. Bertin wrote: > > > When built as SHARED as in the current code, libdraganddropplugin.dylib > > > gets installed to $PREFIX/share/qt5/qml/org/kde/draganddrop, but is given > > > an OS X install_name of $PREFIX/lib/libdraganddropplugin.dylib. This > > >

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-26 Thread David Faure
> On Aug. 25, 2015, 1:41 p.m., David Edmundson wrote: > > I've got both Gentoo and Arch saying this causes a major problem [1]: > > > > libdraganddropplugin.so changes to draganddropplugin.so > > in /usr/lib/qt/qml/org/kde/draganddrop > > > > and then they don't get loaded. > > > > any ideas?

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-25 Thread René J . V . Bertin
> On Aug. 25, 2015, 3:41 p.m., David Edmundson wrote: > > I've got both Gentoo and Arch saying this causes a major problem [1]: > > > > libdraganddropplugin.so changes to draganddropplugin.so > > in /usr/lib/qt/qml/org/kde/draganddrop > > > > and then they don't get loaded. > > > > any ideas?

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-25 Thread Harald Sitter
> On Aug. 25, 2015, 1:41 p.m., David Edmundson wrote: > > I've got both Gentoo and Arch saying this causes a major problem [1]: > > > > libdraganddropplugin.so changes to draganddropplugin.so > > in /usr/lib/qt/qml/org/kde/draganddrop > > > > and then they don't get loaded. > > > > any ideas?

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-25 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124892/#review84338 --- > When built as SHARED as in the current code, libdraganddropp

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-25 Thread David Edmundson
> On Aug. 25, 2015, 1:41 p.m., David Edmundson wrote: > > I've got both Gentoo and Arch saying this causes a major problem [1]: > > > > libdraganddropplugin.so changes to draganddropplugin.so > > in /usr/lib/qt/qml/org/kde/draganddrop > > > > and then they don't get loaded. > > > > any ideas?

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-25 Thread Harald Sitter
> On Aug. 25, 2015, 1:41 p.m., David Edmundson wrote: > > I've got both Gentoo and Arch saying this causes a major problem [1]: > > > > libdraganddropplugin.so changes to draganddropplugin.so > > in /usr/lib/qt/qml/org/kde/draganddrop > > > > and then they don't get loaded. > > > > any ideas?

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-25 Thread Harald Sitter
> On Aug. 25, 2015, 1:41 p.m., David Edmundson wrote: > > I've got both Gentoo and Arch saying this causes a major problem [1]: > > > > libdraganddropplugin.so changes to draganddropplugin.so > > in /usr/lib/qt/qml/org/kde/draganddrop > > > > and then they don't get loaded. > > > > any ideas?

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-25 Thread Harald Sitter
> On Aug. 25, 2015, 1:41 p.m., David Edmundson wrote: > > I've got both Gentoo and Arch saying this causes a major problem [1]: > > > > libdraganddropplugin.so changes to draganddropplugin.so > > in /usr/lib/qt/qml/org/kde/draganddrop > > > > and then they don't get loaded. > > > > any ideas?

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124892/#review84333 --- I've got both Gentoo and Arch saying this causes a major probl

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-23 Thread Hanspeter Niederstrasser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124892/ --- (Updated Aug. 23, 2015, 9:16 p.m.) Status -- This change has been ma

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-23 Thread Hanspeter Niederstrasser
> On Aug. 23, 2015, 1:36 p.m., Hanspeter Niederstrasser wrote: > > Ship It! Oops. My pressing "Ship it" doesn't actually commit. Someone with write access will have to push upstream. Thanks. - Hanspeter --- This is an automatically ge

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-23 Thread Hanspeter Niederstrasser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124892/#review84233 --- Ship it! Ship It! - Hanspeter Niederstrasser On Aug. 23, 2

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-23 Thread Hanspeter Niederstrasser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124892/ --- (Updated Aug. 23, 2015, 1:26 p.m.) Review request for Build System, KDE S

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-23 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124892/#review84226 --- Ship it! I'm not Harald, but no. it won't. - Sune Vuorela

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124892/#review84222 --- +1 from me also, but could you add Harald Sitter to the review

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124892/#review84220 --- +1 seems to make sense but it's not really my area, wait a day

Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-23 Thread Hanspeter Niederstrasser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124892/ --- Review request for Build System, KDE Software on Mac OS X, KDE Frameworks,