Re: Review Request 125152: KBuildSycoca: replace dbus-based locking with a lock file.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125152/#review85232 --- src/sycoca/ksycoca.cpp (line 574)

Re: Review Request 125152: KBuildSycoca: replace dbus-based locking with a lock file.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125152/ --- (Updated Sept. 12, 2015, 2:17 p.m.) Status -- This change has been

Re: Review Request 125152: KBuildSycoca: replace dbus-based locking with a lock file.

> On set. 12, 2015, 8:17 a.m., David Faure wrote: > > src/sycoca/ksycoca.cpp, line 574 > > > > > > Interesting, 3 people (including me) read this code, nobody spotted the > > wrong '!' on this line ;) > >

Re: Review Request 125152: KBuildSycoca: replace dbus-based locking with a lock file.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125152/#review85258 --- Ship it! Ship It! - Albert Astals Cid On set. 11, 2015,

Re: Review Request 125152: KBuildSycoca: replace dbus-based locking with a lock file.

> On Sept. 11, 2015, 12:56 p.m., Albert Astals Cid wrote: > > src/kbuildsycoca/kbuildsycoca.cpp, line 370 > > > > > > .lock() calls scare me, this will block forever if say kbuildsycoca > > crashed, right? > >

Re: Review Request 125152: KBuildSycoca: replace dbus-based locking with a lock file.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125152/ --- (Updated Sept. 11, 2015, 4:27 p.m.) Review request for KDE Frameworks

Review Request 125152: KBuildSycoca: replace dbus-based locking with a lock file.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125152/ --- Review request for KDE Frameworks and Albert Astals Cid. Repository:

Re: Review Request 125152: KBuildSycoca: replace dbus-based locking with a lock file.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125152/#review85220 --- Hmm, this seems to break kservicetest's testKSycocaUpdate()

Re: Review Request 125152: KBuildSycoca: replace dbus-based locking with a lock file.

> On set. 11, 2015, 12:56 p.m., Albert Astals Cid wrote: > > src/kbuildsycoca/kbuildsycoca.cpp, line 370 > > > > > > .lock() calls scare me, this will block forever if say kbuildsycoca > > crashed, right? > >

Re: Review Request 125152: KBuildSycoca: replace dbus-based locking with a lock file.

> On Sept. 11, 2015, 12:56 p.m., Albert Astals Cid wrote: > > src/kbuildsycoca/kbuildsycoca.cpp, line 370 > > > > > > .lock() calls scare me, this will block forever if say kbuildsycoca > > crashed, right? > >

Re: Review Request 125152: KBuildSycoca: replace dbus-based locking with a lock file.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125152/#review85178 --- src/kbuildsycoca/kbuildsycoca.cpp (line 368)