Re: Review Request 125158: add logic to use icons for default xdg user dirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125158/#review90416 --- Would be cool if we could have something like this for

Re: Review Request 125158: add logic to use icons for default xdg user dirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125158/#review87243 --- Ship it! This looks good to me. Don't move the struct out of

Re: Review Request 125158: add logic to use icons for default xdg user dirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125158/ --- (Updated Oct. 22, 2015, 7:26 a.m.) Status -- This change has been

Re: Review Request 125158: add logic to use icons for default xdg user dirs

> On Sept. 21, 2015, 7:22 a.m., David Faure wrote: > > src/core/kfileitem.cpp, line 905 > > > > > > This is much better done by a readonly array, in order to take less > > memory and less CPU time. > > > >

Re: Review Request 125158: add logic to use icons for default xdg user dirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125158/ --- (Updated Oct. 2, 2015, 12:59 p.m.) Review request for KDE Frameworks.

Re: Review Request 125158: add logic to use icons for default xdg user dirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125158/#review86225 --- src/core/kfileitem.cpp (line 903)

Re: Review Request 125158: add logic to use icons for default xdg user dirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125158/#review85235 --- This looks quite inefficient to me. Every time

Re: Review Request 125158: add logic to use icons for default xdg user dirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125158/#review85267 --- Do we really need to add overhead to the icon loading for

Re: Review Request 125158: add logic to use icons for default xdg user dirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125158/ --- (Updated Sept. 12, 2015, 1:29 p.m.) Review request for KDE Frameworks.

Review Request 125158: add logic to use icons for default xdg user dirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125158/ --- Review request for KDE Frameworks. Bugs: 352498