Re: Review Request 125284: make install name of applications.menu file a cached cmake variable

2015-09-25 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125284/ --- (Updated Sept. 25, 2015, 7:47 a.m.) Status -- This change has been

Re: Review Request 125284: make install name of applications.menu file a cached cmake variable

2015-09-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125284/#review85891 --- Ship it! Ship It! - David Faure On Sept. 21, 2015, 11:35

Re: Review Request 125284: make install name of applications.menu file a cached cmake variable

2015-09-21 Thread Harald Sitter
> On Sept. 20, 2015, 6:37 p.m., David Faure wrote: > > CMakeLists.txt, line 33 > > > > > > I'm surprised that this compiles, the double-quotes here usually don't > > end up in the C++ code, (they get eaten by

Re: Review Request 125284: make install name of applications.menu file a cached cmake variable

2015-09-20 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125284/#review85701 --- CMakeLists.txt (line 33)

Review Request 125284: make install name of applications.menu file a cached cmake variable

2015-09-17 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125284/ --- Review request for KDE Frameworks, David Faure, Jonathan Riddell, and Rex

Re: Review Request 125284: make install name of applications.menu file a cached cmake variable

2015-09-17 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125284/#review85585 --- +1 This will save a lot of patch rebasing :D (i'm assuming