Re: Review Request 125762: External extractor plugin support for KFileMetaData

2016-03-26 Thread Boudhayan Gupta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125762/ --- (Updated March 26, 2016, 2:45 p.m.) Status -- This change has been

Re: Review Request 125762: External extractor plugin support for KFileMetaData

2015-12-07 Thread Boudhayan Gupta
> On Dec. 6, 2015, 5:32 p.m., Vishesh Handa wrote: > > If you're planning on pushing this please push it to a testing branch. > > Untill we actually have some plugins using this we might not be sure of the > > API. My points below are quite negative and I was hoping on writing a more > >

Re: Review Request 125762: External extractor plugin support for KFileMetaData

2015-12-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125762/#review89164 --- Ship it! another round of low-level code review; but I'd say

Re: Review Request 125762: External extractor plugin support for KFileMetaData

2015-12-06 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125762/#review89174 --- If you're planning on pushing this please push it to a

Re: Review Request 125762: External extractor plugin support for KFileMetaData

2015-11-08 Thread Boudhayan Gupta
> On Oct. 30, 2015, 12:43 p.m., Boudhayan Gupta wrote: > > Ping? :-) Err, ship it or drop it? It's been about two weeks sitting, so I was hoping to get some feedback now, either way. - Boudhayan --- This is an automatically generated

Re: Review Request 125762: External extractor plugin support for KFileMetaData

2015-10-30 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125762/#review87727 --- src/extractors/externalextractor.cpp (line 69)

Re: Review Request 125762: External extractor plugin support for KFileMetaData

2015-10-30 Thread Boudhayan Gupta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125762/#review87719 --- Ping? :-) - Boudhayan Gupta On Oct. 24, 2015, 5:49 p.m.,

Re: Review Request 125762: External extractor plugin support for KFileMetaData

2015-10-24 Thread Boudhayan Gupta
> On Oct. 24, 2015, 6 p.m., Vishesh Handa wrote: > > I still have many thoughts regarding this particular approach, and third > > party plugins in general. I'm trying to write them into a cohesive blob. Do you mean the entire current extractor interface, or just this patch? What do you mean,

Re: Review Request 125762: External extractor plugin support for KFileMetaData

2015-10-24 Thread Boudhayan Gupta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125762/ --- (Updated Oct. 24, 2015, 5:49 p.m.) Review request for Baloo, KDE

Re: Review Request 125762: External extractor plugin support for KFileMetaData

2015-10-24 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125762/#review87334 --- I still have many thoughts regarding this particular

Re: Review Request 125762: External extractor plugin support for KFileMetaData

2015-10-23 Thread Boudhayan Gupta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125762/ --- (Updated Oct. 23, 2015, 6:58 p.m.) Review request for Baloo, KDE

Re: Review Request 125762: External extractor plugin support for KFileMetaData

2015-10-23 Thread Boudhayan Gupta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125762/ --- (Updated Oct. 23, 2015, 7:10 p.m.) Review request for Baloo, KDE

Review Request 125762: External extractor plugin support for KFileMetaData

2015-10-23 Thread Boudhayan Gupta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125762/ --- Review request for Baloo, KDE Frameworks, Pinak Ahuja, and Vishesh Handa.

Re: Review Request 125762: External extractor plugin support for KFileMetaData

2015-10-23 Thread Boudhayan Gupta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125762/ --- (Updated Oct. 23, 2015, 4:17 p.m.) Review request for Baloo, KDE