Re: Review Request 126001: In KConfigTest::testEntryMap, convert QByteArray with nulls using a char *

2015-11-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126001/#review88194 --- Ship it! Ah, yes, I read the code too fast. Indeed I expect

Re: Review Request 126001: In KConfigTest::testEntryMap, convert QByteArray with nulls using a char *

2015-11-09 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126001/ --- (Updated Nov. 9, 2015, 2:43 p.m.) Status -- This change has been

Re: Review Request 126001: In KConfigTest::testEntryMap, convert QByteArray with nulls using a char *

2015-11-09 Thread Matthew Dawson
> On Nov. 9, 2015, 2:57 a.m., David Faure wrote: > > Isn't this exactly the wrong fix? The goal of the test with embedded NULs > > in a QByteArray is to test that KConfig can be used to store binary data, > > isn't it? So I would think the expected value was correct, it's the KConfig > > code

Review Request 126001: In KConfigTest::testEntryMap, convert QByteArray with nulls using a char *

2015-11-08 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126001/ --- Review request for KDE Frameworks. Repository: kconfig Description

Re: Review Request 126001: In KConfigTest::testEntryMap, convert QByteArray with nulls using a char *

2015-11-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126001/#review88177 --- Isn't this exactly the wrong fix? The goal of the test with