Re: Review Request 126184: Editing toolbars in KXmlGuiWindow sometimes deletes all UI plugged actions

2016-03-05 Thread Jean-Baptiste Mardelle
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126184/ --- (Updated March 5, 2016, 8:25 p.m.) Status -- This change has been

Re: Review Request 126184: Editing toolbars in KXmlGuiWindow sometimes deletes all UI plugged actions

2016-03-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126184/#review93208 --- Ship it! Ship It! - David Faure On March 5, 2016, 8:01

Re: Review Request 126184: Editing toolbars in KXmlGuiWindow sometimes deletes all UI plugged actions

2016-03-05 Thread Jean-Baptiste Mardelle
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126184/ --- (Updated March 5, 2016, 8:01 p.m.) Review request for KDE Frameworks and

Re: Review Request 126184: Editing toolbars in KXmlGuiWindow sometimes deletes all UI plugged actions

2016-03-05 Thread David Faure
> On Dec. 6, 2015, 2:58 p.m., David Faure wrote: > > src/kedittoolbar.cpp, line 770 > > > > > > this code path didn't call accept() before. > > > > Please investigate when save can fail, or keep former

Re: Review Request 126184: Editing toolbars in KXmlGuiWindow sometimes deletes all UI plugged actions

2015-12-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126184/#review89183 --- src/kedittoolbar.cpp (line 770)

Review Request 126184: Editing toolbars in KXmlGuiWindow sometimes deletes all UI plugged actions

2015-11-27 Thread Jean-Baptiste Mardelle
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126184/ --- Review request for KDE Frameworks and David Faure. Bugs: 352882