Re: Review Request 126320: Read KPluginMetada's property X-Plasma-ComponentTypes as a stringlist

2015-12-14 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126320/#review89458 --- Ship it! src/plasma/scripting/scriptengine.cpp (line 89)

Re: Review Request 126320: Read KPluginMetada's property X-Plasma-ComponentTypes as a stringlist

2015-12-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126320/#review89452 --- Ship it! Ship It! - Marco Martin On Dec. 11, 2015, 6:48

Re: Review Request 126320: Read KPluginMetada's property X-Plasma-ComponentTypes as a stringlist

2015-12-14 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126320/ --- (Updated Dec. 14, 2015, 2:05 p.m.) Status -- This change has been

Re: Review Request 126320: Read KPluginMetada's property X-Plasma-ComponentTypes as a stringlist

2015-12-14 Thread Martin Klapetek
> On Dec. 14, 2015, 11:36 a.m., Alex Richardson wrote: > > src/plasma/scripting/scriptengine.cpp, line 67 > > > > > > This should probably also be changed to QStringList? Yes. - Martin

Re: Review Request 126320: Read KPluginMetada's property X-Plasma-ComponentTypes as a stringlist

2015-12-14 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126320/#review89459 --- src/plasma/scripting/scriptengine.cpp (line 67)

Re: Review Request 126320: Read KPluginMetada's property X-Plasma-ComponentTypes as a stringlist

2015-12-13 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126320/#review89424 --- +1 Thank you! This fixes Plasma startup for me and I wasted

Re: Review Request 126320: Read KPluginMetada's property X-Plasma-ComponentTypes as a stringlist

2015-12-12 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126320/#review89394 --- +1, this also fixes plasma on mobile CI - Bhushan Shah On

Re: Review Request 126320: Read KPluginMetada's property X-Plasma-ComponentTypes as a stringlist

2015-12-11 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126320/#review89369 --- i had the similar problem after commit f35e514 (only empty

Review Request 126320: Read KPluginMetada's property X-Plasma-ComponentTypes as a stringlist

2015-12-11 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126320/ --- Review request for KDE Frameworks, Plasma and Alex Richardson.