---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126328/#review89411
---
Ship it!
Ship It!
- Valentin Rusu
On Dec. 12, 2015, 10:59
> On Dec. 13, 2015, 1:01 a.m., Nick Shaforostoff wrote:
> > i suggest using:
> >
> > #ifdef Q_OS_WIN
> > #define U QLatin1String
> > #else
> > #define U QStringLiteral
> > #endif
Patrick's approach corresponds to a widespread practice in KF5 sources. It also
has the advantage to always
> On Dez. 13, 2015, 1:01 vorm., Nick Shaforostoff wrote:
> > i suggest using:
> >
> > #ifdef Q_OS_WIN
> > #define U QLatin1String
> > #else
> > #define U QStringLiteral
> > #endif
>
> Valentin Rusu wrote:
> Patrick's approach corresponds to a widespread practice in KF5 sources.
> It
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126328/
---
(Updated Dec. 13, 2015, 9:57 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126328/#review89407
---
i suggest using:
#ifdef Q_OS_WIN
#define U QLatin1String
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126328/
---
Review request for KDE Frameworks.
Repository: kwallet
Description
