Re: Review Request 126392: Fix some Clazy warnings in kcoreaddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126392/ --- (Updated Dec. 28, 2015, 1:40 p.m.) Status -- This change has been

Re: Review Request 126392: Fix some Clazy warnings in kcoreaddons

> On Dec. 24, 2015, 10:30 a.m., Christian Ehrlicher wrote: > > src/lib/io/kurlmimedata.cpp, line 59 > > > > > > const? Or would this be an ABI breakage? Yes, that can't be changed now. Not because of ABI, but

Re: Review Request 126392: Fix some Clazy warnings in kcoreaddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126392/#review90049 --- src/lib/io/kbackup.cpp (line 114)

Re: Review Request 126392: Fix some Clazy warnings in kcoreaddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126392/ --- (Updated Дек. 24, 2015, 11:58 д.п.) Review request for KDE Frameworks

Re: Review Request 126392: Fix some Clazy warnings in kcoreaddons

> On Дек. 24, 2015, 9:30 д.п., Christian Ehrlicher wrote: > > I corrected the warning Clazy, so what about the first three issues, I do not know anything. 4 issue is fixed. - Andrey --- This is an automatically generated e-mail. To

Re: Review Request 126392: Fix some Clazy warnings in kcoreaddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126392/#review90060 --- src/lib/io/kbackup.cpp (line 86)

Re: Review Request 126392: Fix some Clazy warnings in kcoreaddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126392/#review89994 --- Ship it! Thanks Andrey. Do you have push rights? - Aleix

Re: Review Request 126392: Fix some Clazy warnings in kcoreaddons

> On Дек. 23, 2015, 2:46 п.п., Aleix Pol Gonzalez wrote: > > Thanks Andrey. > > Do you have push rights? No, I do not have permission to push. I posted solution of errors in previous review. - Andrey --- This is an automatically

Re: Review Request 126392: Fix some Clazy warnings in kcoreaddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126392/#review89786 --- Hey, when my patch will be reviewed? - Andrey Cygankov On

Re: Review Request 126392: Fix some Clazy warnings in kcoreaddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126392/#review89795 --- Ship it! Revised patch looks good here. - Michael Pyne On

Re: Review Request 126392: Fix some Clazy warnings in kcoreaddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126392/#review89700 --- src/lib/io/kdirwatch.cpp (line 1067)

Re: Review Request 126392: Fix some Clazy warnings in kcoreaddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126392/#review89697 --- +1 Looks good to me. Just checked and tests still pass. -

Re: Review Request 126392: Fix some Clazy warnings in kcoreaddons

> On Дек. 18, 2015, 12:25 п.п., Emmanuel Pescosta wrote: > > src/lib/io/kdirwatch.cpp, line 1067 > > > > > > This is wrong (if I'm not wrong ;) > > > > De Morgan's law [1] says that A or B <=> not

Re: Review Request 126392: Fix some Clazy warnings in kcoreaddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126392/ --- (Updated Дек. 18, 2015, 4:57 п.п.) Review request for KDE Frameworks and

Re: Review Request 126392: Fix some Clazy warnings in kcoreaddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126392/#review89719 --- src/lib/io/kdirwatch_p.h (line 109)

Review Request 126392: Fix some Clazy warnings in kcoreaddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126392/ --- Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository: