Re: Review Request 126397: [xcb] Safety check whether we have a QApplication in mapViewport

2016-01-14 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126397/ --- (Updated Jan. 14, 2016, 2:59 p.m.) Status -- This change has been

Review Request 126397: [xcb] Safety check whether we have a QApplication in mapViewport

2015-12-17 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126397/ --- Review request for KDE Frameworks, kwin and Albert Astals Cid. Bugs:

Re: Review Request 126397: [xcb] Safety check whether we have a QApplication in mapViewport

2015-12-17 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126397/ --- (Updated Dec. 17, 2015, 10:21 a.m.) Review request for KDE Frameworks,

Re: Review Request 126397: [xcb] Safety check whether we have a QApplication in mapViewport

2015-12-17 Thread Martin Gräßlin
> On Dec. 17, 2015, 1:55 p.m., Thomas Lübking wrote: > > Looks like this boils down to multiple qApp->desktop()->size() calls, ie. > > displayWidth/displayHeight in kwinglobals.h, right? > > > > We could just "borrow" that code and kick the qApp dep then? > > Thomas Lübking wrote: > Ok,

Re: Review Request 126397: [xcb] Safety check whether we have a QApplication in mapViewport

2015-12-17 Thread Thomas Lübking
> On Dec. 17, 2015, 12:55 p.m., Thomas Lübking wrote: > > Looks like this boils down to multiple qApp->desktop()->size() calls, ie. > > displayWidth/displayHeight in kwinglobals.h, right? > > > > We could just "borrow" that code and kick the qApp dep then? Ok, further check - there's another,

Re: Review Request 126397: [xcb] Safety check whether we have a QApplication in mapViewport

2015-12-17 Thread Thomas Lübking
> On Dec. 17, 2015, 12:55 p.m., Thomas Lübking wrote: > > Looks like this boils down to multiple qApp->desktop()->size() calls, ie. > > displayWidth/displayHeight in kwinglobals.h, right? > > > > We could just "borrow" that code and kick the qApp dep then? > > Thomas Lübking wrote: > Ok,

Re: Review Request 126397: [xcb] Safety check whether we have a QApplication in mapViewport

2015-12-17 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126397/#review89648 --- Looks like this boils down to multiple

Re: Review Request 126397: [xcb] Safety check whether we have a QApplication in mapViewport

2015-12-17 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126397/#review89663 --- src/platforms/xcb/kwindowsystem.cpp (line 355)

Re: Review Request 126397: [xcb] Safety check whether we have a QApplication in mapViewport

2015-12-17 Thread Thomas Lübking
> On Dec. 17, 2015, 12:55 p.m., Thomas Lübking wrote: > > Looks like this boils down to multiple qApp->desktop()->size() calls, ie. > > displayWidth/displayHeight in kwinglobals.h, right? > > > > We could just "borrow" that code and kick the qApp dep then? > > Thomas Lübking wrote: > Ok,