Re: Review Request 126650: [WIP] Add PM/ScreenSaver Inhibition capabilities to KIdleTime

2016-12-14 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126650/#review101430 --- FTR org.freedesktop.PowerManagement is deprecated

Re: Review Request 126650: [WIP] Add PM/ScreenSaver Inhibition capabilities to KIdleTime

2016-02-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126650/#review92227 --- Are we convinced that KIdleTime is the best place to put

Re: Review Request 126650: [WIP] Add PM/ScreenSaver Inhibition capabilities to KIdleTime

2016-02-10 Thread Martin Klapetek
> On Feb. 10, 2016, 4:19 p.m., Aleix Pol Gonzalez wrote: > > Are we convinced that KIdleTime is the best place to put this? > > > > KIdleTime definition is: > > > KIdleTime is a singleton reporting information on idle time. It is useful > > > not only for finding out about the current idle

Re: Review Request 126650: [WIP] Add PM/ScreenSaver Inhibition capabilities to KIdleTime

2016-01-29 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126650/#review91774 --- src/inhibition.h (line 136)

Re: Review Request 126650: [WIP] Add PM/ScreenSaver Inhibition capabilities to KIdleTime

2016-01-26 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126650/ --- (Updated Jan. 26, 2016, 7:13 p.m.) Review request for KDE Frameworks and

Re: Review Request 126650: [WIP] Add PM/ScreenSaver Inhibition capabilities to KIdleTime

2016-01-13 Thread Kai Uwe Broulik
> On Jan. 6, 2016, 2:59 nachm., Kai Uwe Broulik wrote: > > src/inhibition.cpp, lines 38-40 > > > > > > initializer list? > > > > Private() > > : status(Inhibition::Inactive) > > , ... > >

Re: Review Request 126650: [WIP] Add PM/ScreenSaver Inhibition capabilities to KIdleTime

2016-01-13 Thread Martin Gräßlin
> On Jan. 11, 2016, 1:05 p.m., Martin Gräßlin wrote: > > src/inhibition.h, line 30 > > > > > > Maybe an explicit InhibitLockScreen? > > Martin Klapetek wrote: > Can add. Btw. is there any dbus interface to

Re: Review Request 126650: [WIP] Add PM/ScreenSaver Inhibition capabilities to KIdleTime

2016-01-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126650/#review90867 --- I'm interested in the reasoning why to put it into KIdleTime?

Re: Review Request 126650: [WIP] Add PM/ScreenSaver Inhibition capabilities to KIdleTime

2016-01-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126650/#review90884 --- nice work! src/CMakeLists.txt (line 27)

Re: Review Request 126650: [WIP] Add PM/ScreenSaver Inhibition capabilities to KIdleTime

2016-01-11 Thread Martin Klapetek
> On Jan. 11, 2016, 1:05 p.m., Martin Gräßlin wrote: > > src/inhibition.h, lines 32-34 > > > > > > Please use lock screen instead of screensaver. These things don't exist > > anymore ;-) xscreensaver? Also the

Re: Review Request 126650: [WIP] Add PM/ScreenSaver Inhibition capabilities to KIdleTime

2016-01-06 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126650/#review90697 --- Nice! I'm wondering how could add additional platform

Re: Review Request 126650: [WIP] Add PM/ScreenSaver Inhibition capabilities to KIdleTime

2016-01-06 Thread Martin Klapetek
> On Jan. 6, 2016, 3:59 p.m., Kai Uwe Broulik wrote: > > autotests/fakePMServer.cpp, line 23 > > > > > > PowerDevil never returns the same cookie more than once, ie. it's just > > ++m_cookieId; Well I don't

Review Request 126650: [WIP] Add PM/ScreenSaver Inhibition capabilities to KIdleTime

2016-01-05 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126650/ --- Review request for KDE Frameworks and Kai Uwe Broulik. Repository: