Re: Review Request 126670: Fix some Clazy warnings in KPeople framework

2016-01-14 Thread Andrey Cygankov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126670/ --- (Updated Jan. 14, 2016, 11:04 p.m.) Status -- This change has been

Re: Review Request 126670: Fix some Clazy warnings in KPeople framework

2016-01-08 Thread David Faure
> On Jan. 8, 2016, 1:20 a.m., Aleix Pol Gonzalez wrote: > > I did it myself because you're a GCI student, but besides compilation, you > > should have checked if tests still pass and specified so in the testing > > field. > > > > The change looks, good. Thanks! > > Andrey Cygankov wrote: >

Re: Review Request 126670: Fix some Clazy warnings in KPeople framework

2016-01-08 Thread Andrey Cygankov
> On Янв. 8, 2016, 1:20 д.п., Aleix Pol Gonzalez wrote: > > I did it myself because you're a GCI student, but besides compilation, you > > should have checked if tests still pass and specified so in the testing > > field. > > > > The change looks, good. Thanks! > > Andrey Cygankov wrote: >

Re: Review Request 126670: Fix some Clazy warnings in KPeople framework

2016-01-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126670/#review90784 --- Ship it! I did it myself because you're a GCI student, but

Re: Review Request 126670: Fix some Clazy warnings in KPeople framework

2016-01-07 Thread Andrey Cygankov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126670/ --- (Updated Jan. 8, 2016, 2:15 a.m.) Review request for KDE Frameworks and

Re: Review Request 126670: Fix some Clazy warnings in KPeople framework

2016-01-07 Thread Andrey Cygankov
> On Янв. 8, 2016, 1:20 д.п., Aleix Pol Gonzalez wrote: > > I did it myself because you're a GCI student, but besides compilation, you > > should have checked if tests still pass and specified so in the testing > > field. > > > > The change looks, good. Thanks! Please tell me how to run the