Re: Review Request 126723: Add wrapper for polkit_system_bus_name_get_user_sync

2016-01-14 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126723/ --- (Updated Jan. 14, 2016, 11:02 a.m.) Status -- This change has been

Re: Review Request 126723: Add wrapper for polkit_system_bus_name_get_user_sync

2016-01-13 Thread Martin Gräßlin
> On Jan. 12, 2016, 3:43 p.m., David Edmundson wrote: > > core/polkitqt1-subject.cpp, line 184 > > > > > > Identity > > whcih this inherits from > > > > has a QExplicitlySharedDataPointer for it's

Re: Review Request 126723: Add wrapper for polkit_system_bus_name_get_user_sync

2016-01-13 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126723/ --- (Updated Jan. 13, 2016, 11:52 a.m.) Review request for KDE Frameworks,

Re: Review Request 126723: Add wrapper for polkit_system_bus_name_get_user_sync

2016-01-13 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126723/#review91014 --- Ship it! Ship It! - David Edmundson On Jan. 13, 2016,

Re: Review Request 126723: Add wrapper for polkit_system_bus_name_get_user_sync

2016-01-12 Thread Matthias Klumpp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126723/#review90956 --- Patch looks good - normally I would say that the build-deps

Review Request 126723: Add wrapper for polkit_system_bus_name_get_user_sync

2016-01-12 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126723/ --- Review request for KDE Frameworks, David Edmundson, Hrvoje Senjan, and

Re: Review Request 126723: Add wrapper for polkit_system_bus_name_get_user_sync

2016-01-12 Thread Martin Gräßlin
> On Jan. 12, 2016, 10:43 a.m., Matthias Klumpp wrote: > > Patch looks good - normally I would say that the build-deps need to be > > bumped to request an appropriate Polkit version (0.113), but e.g. Debian > > backports this change to the older 0.105 release - and that seems to be > > quite

Re: Review Request 126723: Add wrapper for polkit_system_bus_name_get_user_sync

2016-01-12 Thread Hrvoje Senjan
> On Jan. 12, 2016, 10:43 a.m., Matthias Klumpp wrote: > > Patch looks good - normally I would say that the build-deps need to be > > bumped to request an appropriate Polkit version (0.113), but e.g. Debian > > backports this change to the older 0.105 release - and that seems to be > > quite

Re: Review Request 126723: Add wrapper for polkit_system_bus_name_get_user_sync

2016-01-12 Thread Martin Gräßlin
> On Jan. 12, 2016, 10:43 a.m., Matthias Klumpp wrote: > > Patch looks good - normally I would say that the build-deps need to be > > bumped to request an appropriate Polkit version (0.113), but e.g. Debian > > backports this change to the older 0.105 release - and that seems to be > > quite

Re: Review Request 126723: Add wrapper for polkit_system_bus_name_get_user_sync

2016-01-12 Thread Martin Gräßlin
> On Jan. 12, 2016, 10:43 a.m., Matthias Klumpp wrote: > > Patch looks good - normally I would say that the build-deps need to be > > bumped to request an appropriate Polkit version (0.113), but e.g. Debian > > backports this change to the older 0.105 release - and that seems to be > > quite

Re: Review Request 126723: Add wrapper for polkit_system_bus_name_get_user_sync

2016-01-12 Thread Hrvoje Senjan
> On Jan. 12, 2016, 10:43 a.m., Matthias Klumpp wrote: > > Patch looks good - normally I would say that the build-deps need to be > > bumped to request an appropriate Polkit version (0.113), but e.g. Debian > > backports this change to the older 0.105 release - and that seems to be > > quite

Re: Review Request 126723: Add wrapper for polkit_system_bus_name_get_user_sync

2016-01-12 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126723/#review90970 --- core/polkitqt1-subject.cpp (line 184)