Re: Review Request 126735: Fix most Clazy warnings in KItemModels.

2016-01-19 Thread Kåre Särs
> On Jan. 14, 2016, 8:47 a.m., Kåre Särs wrote: > > tests/proxymodeltestapp/proxyitemselectionwidget.cpp, line 47 > > > > > > QStringLiteral with multiple string initializers does not work on > > Windows. All

Re: Review Request 126735: Fix most Clazy warnings in KItemModels.

2016-01-18 Thread David Faure
> On Jan. 14, 2016, 8:47 a.m., Kåre Särs wrote: > > tests/proxymodeltestapp/proxyitemselectionwidget.cpp, line 47 > > > > > > QStringLiteral with multiple string initializers does not work on > > Windows. All

Re: Review Request 126735: Fix most Clazy warnings in KItemModels.

2016-01-14 Thread Andrey Cygankov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126735/ --- (Updated Янв. 14, 2016, 8:52 д.п.) Review request for KDE Frameworks and

Re: Review Request 126735: Fix most Clazy warnings in KItemModels.

2016-01-14 Thread Kåre Särs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126735/#review91051 --- tests/proxymodeltestapp/proxyitemselectionwidget.cpp (line

Re: Review Request 126735: Fix most Clazy warnings in KItemModels.

2016-01-14 Thread Kåre Särs
> On Jan. 14, 2016, 8:47 a.m., Kåre Särs wrote: > > tests/proxymodeltestapp/proxyitemselectionwidget.cpp, line 47 > > > > > > QStringLiteral with multiple string initializers does not work on > > Windows. All

Re: Review Request 126735: Fix most Clazy warnings in KItemModels.

2016-01-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126735/#review91073 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 14, 2016,

Re: Review Request 126735: Fix most Clazy warnings in KItemModels.

2016-01-14 Thread Aleix Pol Gonzalez
> On Jan. 14, 2016, 9:47 a.m., Kåre Särs wrote: > > tests/proxymodeltestapp/proxyitemselectionwidget.cpp, line 47 > > > > > > QStringLiteral with multiple string initializers does not work on > > Windows. All

Re: Review Request 126735: Fix most Clazy warnings in KItemModels.

2016-01-14 Thread Andrey Cygankov
> On Янв. 14, 2016, 12:07 д.п., Aleix Pol Gonzalez wrote: > > These look good. You wrote "most". Which warnings couldn't you fix? > > Andrey Cygankov wrote: > log file sent > > Aleix Pol Gonzalez wrote: > >

Re: Review Request 126735: Fix most Clazy warnings in KItemModels.

2016-01-14 Thread Andrey Cygankov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126735/ --- (Updated Jan. 14, 2016, 11:16 p.m.) Status -- This change has been

Re: Review Request 126735: Fix most Clazy warnings in KItemModels.

2016-01-14 Thread Andrey Cygankov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126735/ --- (Updated Янв. 14, 2016, 11 п.п.) Review request for KDE Frameworks and

Review Request 126735: Fix most Clazy warnings in KItemModels.

2016-01-13 Thread Andrey Cygankov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126735/ --- Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository:

Re: Review Request 126735: Fix most Clazy warnings in KItemModels.

2016-01-13 Thread Aleix Pol Gonzalez
> On Jan. 14, 2016, 1:07 a.m., Aleix Pol Gonzalez wrote: > > These look good. You wrote "most". Which warnings couldn't you fix? > > Andrey Cygankov wrote: > log file sent `/home/andrey/dev/projects/kitemmodels/autotests/proxymodeltestsuite/proxymodeltest.h:762:17: note: expanded from

Re: Review Request 126735: Fix most Clazy warnings in KItemModels.

2016-01-13 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126735/#review91040 --- These look good. You wrote "most". Which warnings couldn't

Re: Review Request 126735: Fix most Clazy warnings in KItemModels.

2016-01-13 Thread Andrey Cygankov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126735/ --- (Updated Янв. 14, 2016, 12:24 д.п.) Review request for KDE Frameworks

Re: Review Request 126735: Fix most Clazy warnings in KItemModels.

2016-01-13 Thread Andrey Cygankov
> On Янв. 14, 2016, 12:07 д.п., Aleix Pol Gonzalez wrote: > > These look good. You wrote "most". Which warnings couldn't you fix? log file sent - Andrey --- This is an automatically generated e-mail. To reply, visit: