Re: Review Request 127211: Properly use static QMaps

2016-02-29 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127211/ --- (Updated Feb. 29, 2016, 7:26 p.m.) Status -- This change has been

Re: Review Request 127211: Properly use static QMaps

2016-02-29 Thread Sergio Martins
> On Feb. 29, 2016, 10:36 a.m., Milian Wolff wrote: > > even better would be to use > > > > static const QHash map = { > > {QStringLiteral(...), value}, // NOTE: don't use QLatin1String here! > > ... > > }; > > return map[mapCommand]; QStringLiteral

Re: Review Request 127211: Properly use static QMaps

2016-02-29 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127211/#review92889 --- Ship it! even better would be to use static const

Re: Review Request 127211: Properly use static QMaps

2016-02-28 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127211/#review92877 --- Ship it! Ship It! - Kevin Funk On Feb. 28, 2016, 9:52

Review Request 127211: Properly use static QMaps

2016-02-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127211/ --- Review request for Kate and KDE Frameworks. Repository: ktexteditor