Re: Review Request 127245: Fix Kdelibs4 config migration for Windows

2016-03-03 Thread Andre Heinecke
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127245/ --- (Updated March 3, 2016, 1:28 p.m.) Status -- This change has been

Re: Review Request 127245: Fix Kdelibs4 config migration for Windows

2016-03-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127245/#review93083 --- Ship it! Thanks, looks more correct indeed. - David

Re: Review Request 127245: Fix Kdelibs4 config migration for Windows

2016-03-02 Thread Andre Heinecke
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127245/ --- (Updated March 2, 2016, 11:04 a.m.) Review request for KDE Frameworks.

Re: Review Request 127245: Fix Kdelibs4 config migration for Windows

2016-03-02 Thread Andre Heinecke
> On March 2, 2016, 8:19 a.m., David Faure wrote: > > I couldn't find "AppData" or "Roaming" in kdelibs4 though. Did this come > > from windows API calls, or from kdewin maybe? Just wanted to check it was > > the exact same logic as in kdelibs4... In kdecore/kernel/kstandarddirs.cpp line 1733

Re: Review Request 127245: Fix Kdelibs4 config migration for Windows

2016-03-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127245/#review93055 --- Ship it! I couldn't find "AppData" or "Roaming" in

Review Request 127245: Fix Kdelibs4 config migration for Windows

2016-03-01 Thread Andre Heinecke
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127245/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description