Re: Review Request 127386: kio-extras mtp protocol: Add support for Windows Phones

2016-03-31 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127386/ --- (Updated March 31, 2016, 1:12 p.m.) Status -- This change has been m

Re: Review Request 127386: kio-extras mtp protocol: Add support for Windows Phones

2016-03-31 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127386/#review94145 --- Ship it! Ship It! - Marco Martin On March 16, 2016, 4:4

Re: Review Request 127386: kio-extras mtp protocol: Add support for Windows Phones

2016-03-23 Thread Dominik Haumann
> On March 17, 2016, 5:26 p.m., Dominik Haumann wrote: > > The only real difference to the original version is that the line > > > > int isMtpDevice = LIBMTP_Check_Specific_Device(solidBusNum, > > solidDevNum); > > > > is removed. This somehow implies that this check is too restrictive. If

Re: Review Request 127386: kio-extras mtp protocol: Add support for Windows Phones

2016-03-19 Thread Dominik Haumann
> On March 16, 2016, 1:24 a.m., David Edmundson wrote: > > mtp/devicecache.cpp, line 116 > > > > > > int isMtpDevice = LIBMTP_Check_Specific_Device(solidBusNum, > > solidDevNum); > > > > this line looks

Re: Review Request 127386: kio-extras mtp protocol: Add support for Windows Phones

2016-03-19 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127386/#review93660 --- The only real difference to the original version is that the

Re: Review Request 127386: kio-extras mtp protocol: Add support for Windows Phones

2016-03-19 Thread Dominik Haumann
> On March 17, 2016, 5:26 p.m., Dominik Haumann wrote: > > The only real difference to the original version is that the line > > > > int isMtpDevice = LIBMTP_Check_Specific_Device(solidBusNum, > > solidDevNum); > > > > is removed. This somehow implies that this check is too restrictive. If

Re: Review Request 127386: kio-extras mtp protocol: Add support for Windows Phones

2016-03-19 Thread Dominik Haumann
> On März 17, 2016, 5:26 nachm., Dominik Haumann wrote: > > The only real difference to the original version is that the line > > > > int isMtpDevice = LIBMTP_Check_Specific_Device(solidBusNum, > > solidDevNum); > > > > is removed. This somehow implies that this check is too restrictive. I

Re: Review Request 127386: kio-extras mtp protocol: Add support for Windows Phones

2016-03-19 Thread Dominik Haumann
> On March 17, 2016, 5:26 p.m., Dominik Haumann wrote: > > The only real difference to the original version is that the line > > > > int isMtpDevice = LIBMTP_Check_Specific_Device(solidBusNum, > > solidDevNum); > > > > is removed. This somehow implies that this check is too restrictive. If

Re: Review Request 127386: kio-extras mtp protocol: Add support for Windows Phones

2016-03-19 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127386/ --- (Updated March 16, 2016, 4:41 p.m.) Review request for KDE Frameworks, Da

Re: Review Request 127386: kio-extras mtp protocol: Add support for Windows Phones

2016-03-16 Thread Kai Uwe Broulik
> On März 16, 2016, 1:24 vorm., David Edmundson wrote: > > mtp/devicecache.cpp, line 116 > > > > > > int isMtpDevice = LIBMTP_Check_Specific_Device(solidBusNum, > > solidDevNum); > > > > this line looks

Re: Review Request 127386: kio-extras mtp protocol: Add support for Windows Phones

2016-03-16 Thread Dominik Haumann
> On March 16, 2016, 1:24 a.m., David Edmundson wrote: > > mtp/devicecache.cpp, line 116 > > > > > > int isMtpDevice = LIBMTP_Check_Specific_Device(solidBusNum, > > solidDevNum); > > > > this line looks

Re: Review Request 127386: kio-extras mtp protocol: Add support for Windows Phones

2016-03-15 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127386/#review93581 --- mtp/devicecache.cpp (line 113)

Review Request 127386: kio-extras mtp protocol: Add support for Windows Phones

2016-03-15 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127386/ --- Review request for KDE Frameworks, David Faure and Philipp Schmidt. Bugs: