Re: Review Request 127729: Explicitly define NOMINMAX to avoid conflict with the 'max' macro definition
> On Abril 23, 2016, 11:40 p.m., Michael Pyne wrote: > > This is a duplicate of RR 127598, which is about to get marked as 'change > > then commit' (I missed that it was updated a few days ago when my email was > > futzy :( ). Thanks! I'm discarding this one, then. - Andrius da Costa --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127729/#review94797 --- On Abril 23, 2016, 11:54 p.m., Andrius da Costa Ribas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127729/ > --- > > (Updated Abril 23, 2016, 11:54 p.m.) > > > Review request for KDE Frameworks and kdewin. > > > Repository: kcoreaddons > > > Description > --- > > Although there is currently no problem on building kcoreaddons, when building > okular (and possibly other apps) the compiler gets confused when it reaches > std::numeric_limits::max() as is also included and it > defines a 'max' macro. > > > Diffs > - > > src/lib/util/kuser.h 3c9ff00 > > Diff: https://git.reviewboard.kde.org/r/127729/diff/ > > > Testing > --- > > Okular is buildable on MSVC after this patch. No further testing done. > > > Thanks, > > Andrius da Costa Ribas > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127729: Explicitly define NOMINMAX to avoid conflict with the 'max' macro definition
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127729/ --- (Updated Abril 23, 2016, 11:54 p.m.) Status -- This change has been discarded. Review request for KDE Frameworks and kdewin. Repository: kcoreaddons Description --- Although there is currently no problem on building kcoreaddons, when building okular (and possibly other apps) the compiler gets confused when it reaches std::numeric_limits::max() as is also included and it defines a 'max' macro. Diffs - src/lib/util/kuser.h 3c9ff00 Diff: https://git.reviewboard.kde.org/r/127729/diff/ Testing --- Okular is buildable on MSVC after this patch. No further testing done. Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127729: Explicitly define NOMINMAX to avoid conflict with the 'max' macro definition
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127729/#review94797 --- This is a duplicate of RR 127598, which is about to get marked as 'change then commit' (I missed that it was updated a few days ago when my email was futzy :( ). - Michael Pyne On April 23, 2016, 5:46 p.m., Andrius da Costa Ribas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127729/ > --- > > (Updated April 23, 2016, 5:46 p.m.) > > > Review request for KDE Frameworks and kdewin. > > > Repository: kcoreaddons > > > Description > --- > > Although there is currently no problem on building kcoreaddons, when building > okular (and possibly other apps) the compiler gets confused when it reaches > std::numeric_limits::max() as is also included and it > defines a 'max' macro. > > > Diffs > - > > src/lib/util/kuser.h 3c9ff00 > > Diff: https://git.reviewboard.kde.org/r/127729/diff/ > > > Testing > --- > > Okular is buildable on MSVC after this patch. No further testing done. > > > Thanks, > > Andrius da Costa Ribas > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
