Re: Review Request 127813: Process paths just once

2016-05-11 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127813/#review95399 --- General +1 from me, just two things: 1) Can you split these

Re: Review Request 127813: Process paths just once

2016-05-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127813/#review95393 --- ping? - Aleix Pol Gonzalez On May 5, 2016, 3:02 a.m.,

Re: Review Request 127813: Process paths just once

2016-05-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127813/ --- (Updated May 5, 2016, 3:02 a.m.) Review request for KDE Frameworks and

Re: Review Request 127813: Process paths just once

2016-05-04 Thread Andreas Hartmetz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127813/#review95192 --- src/core/kconfiggroup.cpp (line 439)

Re: Review Request 127813: Process paths just once

2016-05-04 Thread Albert Astals Cid
> On May 2, 2016, 8:21 p.m., Albert Astals Cid wrote: > > src/core/kconfiggroup.cpp, line 442 > > > > > > Are we sure we want this to be static? > > Aleix Pol Gonzalez wrote: > I'm not sure, my impression

Re: Review Request 127813: Process paths just once

2016-05-02 Thread Aleix Pol Gonzalez
> On May 2, 2016, 10:21 p.m., Albert Astals Cid wrote: > > src/core/kconfiggroup.cpp, line 442 > > > > > > Are we sure we want this to be static? I'm not sure, my impression is that it's better if we only fetch

Review Request 127813: Process paths just once

2016-05-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127813/ --- Review request for KDE Frameworks and Matthew Dawson. Repository: