Re: Review Request 127887: Improve usage of Qt APIs

2016-05-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127887/ --- (Updated May 23, 2016, 10:50 a.m.) Status -- This change has been

Re: Review Request 127887: Improve usage of Qt APIs

2016-05-18 Thread Aleix Pol Gonzalez
> On May 17, 2016, 10:46 p.m., Gregor Mi wrote: > > src/core/installation.cpp, line 383 > > > > > > I don't know if this does the same but also didn't test. It uses QStandardPaths to actively look-up instead of

Re: Review Request 127887: Improve usage of Qt APIs

2016-05-17 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127887/#review95562 --- Looks fine to me. I opened two issues but these are just

Re: Review Request 127887: Improve usage of Qt APIs

2016-05-17 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127887/#review95561 --- src/core/installation.cpp (line 382)

Re: Review Request 127887: Improve usage of Qt APIs

2016-05-12 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127887/#review95428 --- The knewstuff (non moretools) side looks good to me. -

Re: Review Request 127887: Improve usage of Qt APIs

2016-05-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127887/ --- (Updated May 12, 2016, 1:01 a.m.) Review request for KDE Frameworks and

Review Request 127887: Improve usage of Qt APIs

2016-05-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127887/ --- Review request for KDE Frameworks and Jeremy Whiting. Repository: