Re: Review Request 128219: No longer allow installing to generic data folder because of security hole.

2016-08-15 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128219/ --- (Updated Aug. 15, 2016, 9:49 a.m.) Status -- This change has been

Re: Review Request 128219: No longer allow installing to generic data folder because of security hole.

2016-08-14 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128219/#review98380 --- Ship it! Looks good to me, thanks. And since this wasn't

Re: Review Request 128219: No longer allow installing to generic data folder because of security hole.

2016-08-12 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128219/ --- (Updated Aug. 12, 2016, 12:58 p.m.) Review request for KDE Frameworks,

Re: Review Request 128219: No longer allow installing to generic data folder because of security hole.

2016-08-12 Thread David Faure
> On June 17, 2016, 7:36 a.m., David Faure wrote: > > src/core/installation.cpp, line 379 > > > > > > There are of course other values for targetDirectory which would create > > problems. > > - "//" > >

Re: Review Request 128219: No longer allow installing to generic data folder because of security hole.

2016-07-01 Thread David Faure
> On June 17, 2016, 7:36 a.m., David Faure wrote: > > src/core/installation.cpp, line 379 > > > > > > There are of course other values for targetDirectory which would create > > problems. > > - "//" > >

Re: Review Request 128219: No longer allow installing to generic data folder because of security hole.

2016-06-29 Thread Jeremy Whiting
> On June 17, 2016, 1:36 a.m., David Faure wrote: > > src/core/installation.cpp, line 379 > > > > > > There are of course other values for targetDirectory which would create > > problems. > > - "//" > >

Re: Review Request 128219: No longer allow installing to generic data folder because of security hole.

2016-06-17 Thread Jeremy Whiting
> On June 17, 2016, 1:36 a.m., David Faure wrote: > > src/core/installation.cpp, line 365 > > > > > > Should this code get support for "appdata" then? > > (typically share/kmyapp) > > > >

Re: Review Request 128219: No longer allow installing to generic data folder because of security hole.

2016-06-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128219/#review96621 --- src/core/installation.cpp (line 365)

Review Request 128219: No longer allow installing to generic data folder because of security hole.

2016-06-16 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128219/ --- Review request for KDE Frameworks, David Faure and Richard Moore.