Re: Review Request 128340: Don't use QQuickWidget::quickWindow() as it was added in Qt 5.5

2016-07-03 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128340/ --- (Updated July 3, 2016, 1:05 p.m.) Status -- This change has been

Re: Review Request 128340: Don't use QQuickWidget::quickWindow() as it was added in Qt 5.5

2016-07-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128340/#review97014 --- Ship it! Ship It! - David Faure On July 2, 2016, 8:59

Re: Review Request 128340: Don't use QQuickWidget::quickWindow() as it was added in Qt 5.5

2016-07-02 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128340/ --- (Updated July 2, 2016, 8:59 a.m.) Review request for KDE Frameworks and

Re: Review Request 128340: Don't use QQuickWidget::quickWindow() as it was added in Qt 5.5

2016-07-02 Thread David Rosca
> On July 2, 2016, 8:53 a.m., David Faure wrote: > > Thanks for the very quick fix. Unfortunately I don't know enough about > > QQuickWidget to approve. > > > > Just wondering: in the testing section, you don't mention that you actually > > tested runtime behaviour with this change? ;) Ah

Re: Review Request 128340: Don't use QQuickWidget::quickWindow() as it was added in Qt 5.5

2016-07-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128340/#review97009 --- Thanks for the very quick fix. Unfortunately I don't know

Review Request 128340: Don't use QQuickWidget::quickWindow() as it was added in Qt 5.5

2016-07-02 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128340/ --- Review request for KDE Frameworks and David Faure. Repository: kcmutils