Re: Review Request 128397: KIconEngine: Fix QIcon::hasThemeIcon always returning true

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128397/ --- (Updated July 12, 2016, 12:55 a.m.) Status -- This change has been

Re: Review Request 128397: KIconEngine: Fix QIcon::hasThemeIcon always returning true

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128397/#review97294 --- Is this same as https://bugs.kde.org/show_bug.cgi?id=365355

Re: Review Request 128397: KIconEngine: Fix QIcon::hasThemeIcon always returning true

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128397/#review97221 --- Compiled and tested on archlinux: it fixed

Re: Review Request 128397: KIconEngine: Fix QIcon::hasThemeIcon always returning true

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128397/ --- (Updated July 8, 2016, 12:24 p.m.) Review request for KDE Frameworks and

Re: Review Request 128397: KIconEngine: Fix QIcon::hasThemeIcon always returning true

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128397/#review97213 --- I think this would fix that as well ?

Re: Review Request 128397: KIconEngine: Fix QIcon::hasThemeIcon always returning true

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128397/ --- (Updated July 8, 2016, 10:52 a.m.) Review request for KDE Frameworks and

Re: Review Request 128397: KIconEngine: Fix QIcon::hasThemeIcon always returning true

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128397/#review97193 --- src/kiconengine.cpp (line 164)

Re: Review Request 128397: KIconEngine: Fix QIcon::hasThemeIcon always returning true

> On July 7, 2016, 9:59 p.m., David Faure wrote: > > autotests/kiconengine_unittest.cpp, line 69 > > > > > > What's the problem if name() returns "invalid-icon-name" here? ``` bool QIcon::hasThemeIcon(const

Re: Review Request 128397: KIconEngine: Fix QIcon::hasThemeIcon always returning true

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128397/#review97181 --- Thanks for looking into this!

Review Request 128397: KIconEngine: Fix QIcon::hasThemeIcon always returning true

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128397/ --- Review request for KDE Frameworks. Repository: kiconthemes Description