Re: Review Request 128398: Fix KDescendantsProxyModel::setSourceModel(...) to reset internal data

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128398/ --- (Updated Aug. 2, 2016, 2:24 p.m.) Status -- This change has been dis

Re: Review Request 128398: Fix KDescendantsProxyModel::setSourceModel(...) to reset internal data

> On July 21, 2016, 5:43 a.m., Sune Vuorela wrote: > > I tried writing a small test for it, and it seemed like I could reproduce > > the issue. But my test didn't pass when I added this changeset. > > > > Maybe I should publish my test case somewhere... > > Sune Vuorela wrote: > https://gi

Re: Review Request 128398: Fix KDescendantsProxyModel::setSourceModel(...) to reset internal data

> On July 21, 2016, 5:43 a.m., Sune Vuorela wrote: > > I tried writing a small test for it, and it seemed like I could reproduce > > the issue. But my test didn't pass when I added this changeset. > > > > Maybe I should publish my test case somewhere... https://git.reviewboard.kde.org/r/128513

Re: Review Request 128398: Fix KDescendantsProxyModel::setSourceModel(...) to reset internal data

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128398/#review97685 --- I tried writing a small test for it, and it seemed like I cou

Re: Review Request 128398: Fix KDescendantsProxyModel::setSourceModel(...) to reset internal data

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128398/#review97444 --- I'd recommend making a new unittest with simply a QStandardIt

Review Request 128398: Fix KDescendantsProxyModel::setSourceModel(...) to reset internal data

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128398/ --- Review request for KDE Frameworks, Stephen Kelly and Stephen Kelly. Repo