Re: Review Request 128580: If we pass a QIcon as an argument to IconItem::Source, use it

2016-08-03 Thread David Edmundson
> On Aug. 3, 2016, 7:38 a.m., David Rosca wrote: > > Why does it break for SNIs? It first tries QIcon::fromTheme and if it fails > > (isNull()) fallbacks to original QIcon. This patch just switched it, why > > does it make a difference? > > > > The problem I see here is that if a custom icon

Re: Review Request 128580: If we pass a QIcon as an argument to IconItem::Source, use it

2016-08-03 Thread David Rosca
> On Aug. 3, 2016, 7:38 a.m., David Rosca wrote: > > Why does it break for SNIs? It first tries QIcon::fromTheme and if it fails > > (isNull()) fallbacks to original QIcon. This patch just switched it, why > > does it make a difference? > > > > The problem I see here is that if a custom icon

Re: Review Request 128580: If we pass a QIcon as an argument to IconItem::Source, use it

2016-08-03 Thread Kai Uwe Broulik
> On Aug. 3, 2016, 7:38 vorm., David Rosca wrote: > > Why does it break for SNIs? It first tries QIcon::fromTheme and if it fails > > (isNull()) fallbacks to original QIcon. This patch just switched it, why > > does it make a difference? > > > > The problem I see here is that if a custom icon

Re: Review Request 128580: If we pass a QIcon as an argument to IconItem::Source, use it

2016-08-03 Thread David Rosca
> On Aug. 3, 2016, 7:38 a.m., David Rosca wrote: > > Why does it break for SNIs? It first tries QIcon::fromTheme and if it fails > > (isNull()) fallbacks to original QIcon. This patch just switched it, why > > does it make a difference? > > > > The problem I see here is that if a custom icon

Re: Review Request 128580: If we pass a QIcon as an argument to IconItem::Source, use it

2016-08-03 Thread David Edmundson
> On Aug. 3, 2016, 7:38 a.m., David Rosca wrote: > > Why does it break for SNIs? It first tries QIcon::fromTheme and if it fails > > (isNull()) fallbacks to original QIcon. This patch just switched it, why > > does it make a difference? > > > > The problem I see here is that if a custom icon

Re: Review Request 128580: If we pass a QIcon as an argument to IconItem::Source, use it

2016-08-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128580/ --- (Updated Aug. 3, 2016, 11:05 a.m.) Status -- This change has been

Re: Review Request 128580: If we pass a QIcon as an argument to IconItem::Source, use it

2016-08-03 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128580/#review98044 --- Can we have an autotest for this custom iconloader case? -

Re: Review Request 128580: If we pass a QIcon as an argument to IconItem::Source, use it

2016-08-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128580/#review98039 --- Ship it! Ship It! - Marco Martin On Aug. 2, 2016, 9:11

Re: Review Request 128580: If we pass a QIcon as an argument to IconItem::Source, use it

2016-08-03 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128580/#review98035 --- Why does it break for SNIs? It first tries QIcon::fromTheme

Review Request 128580: If we pass a QIcon as an argument to IconItem::Source, use it

2016-08-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128580/ --- Review request for KDE Frameworks and Plasma. Repository: