Re: Review Request 128852: In listview mode use the default implemention of moveCursor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128852/ --- (Updated Sept. 27, 2016, 12:14 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kitemviews Description --- KCategorizedView overrides the moveCursor to handle moving the cursor in the grid; however it's own implementation doesn't handle key up/down when it's not in an exact grid mode; which happens to also include list mode. In this case we don't need anything custom and the QListView implementation works perfectly. This fixes KPluginSelector keyboard navigation. Diffs - src/kcategorizedview.cpp 7e60a38060dc18fbe546495cfb0fdd64ec5b95d1 Diff: https://git.reviewboard.kde.org/r/128852/diff/ Testing --- Thanks, David Edmundson
Re: Review Request 128852: In listview mode use the default implemention of moveCursor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128852/#review98984 --- Ship it! Ship It! - Dominik Haumann On Sept. 6, 2016, 3:45 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128852/ > --- > > (Updated Sept. 6, 2016, 3:45 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kitemviews > > > Description > --- > > KCategorizedView overrides the moveCursor to handle moving the cursor in > the grid; however it's own implementation doesn't handle key up/down > when it's not in an exact grid mode; which happens to also include list > mode. > > In this case we don't need anything custom and the QListView > implementation works perfectly. > > This fixes KPluginSelector keyboard navigation. > > > Diffs > - > > src/kcategorizedview.cpp 7e60a38060dc18fbe546495cfb0fdd64ec5b95d1 > > Diff: https://git.reviewboard.kde.org/r/128852/diff/ > > > Testing > --- > > > Thanks, > > David Edmundson > >
Re: Review Request 128852: In listview mode use the default implemention of moveCursor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128852/#review98943 --- This patch fixes keyboard navigation in KDevelop's plugin config page, so obviously an improvement. Another review won't hurt, though. - Dominik Haumann On Sept. 6, 2016, 3:45 nachm., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128852/ > --- > > (Updated Sept. 6, 2016, 3:45 nachm.) > > > Review request for KDE Frameworks. > > > Repository: kitemviews > > > Description > --- > > KCategorizedView overrides the moveCursor to handle moving the cursor in > the grid; however it's own implementation doesn't handle key up/down > when it's not in an exact grid mode; which happens to also include list > mode. > > In this case we don't need anything custom and the QListView > implementation works perfectly. > > This fixes KPluginSelector keyboard navigation. > > > Diffs > - > > src/kcategorizedview.cpp 7e60a38060dc18fbe546495cfb0fdd64ec5b95d1 > > Diff: https://git.reviewboard.kde.org/r/128852/diff/ > > > Testing > --- > > > Thanks, > > David Edmundson > >
Review Request 128852: In listview mode use the default implemention of moveCursor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128852/ --- Review request for KDE Frameworks. Repository: kitemviews Description --- KCategorizedView overrides the moveCursor to handle moving the cursor in the grid; however it's own implementation doesn't handle key up/down when it's not in an exact grid mode; which happens to also include list mode. In this case we don't need anything custom and the QListView implementation works perfectly. This fixes KPluginSelector keyboard navigation. Diffs - src/kcategorizedview.cpp 7e60a38060dc18fbe546495cfb0fdd64ec5b95d1 Diff: https://git.reviewboard.kde.org/r/128852/diff/ Testing --- Thanks, David Edmundson
