Re: Review Request 128916: kconfig: Make test XFAIL when running as root

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128916/ --- (Updated Sept. 29, 2016, 3:41 p.m.) Status -- This change has been m

Re: Review Request 128916: kconfig: Make test XFAIL when running as root

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128916/#review99644 --- Ship it! Ship It! - David Faure On Sept. 19, 2016, 6:14

Re: Review Request 128916: kconfig: Make test XFAIL when running as root

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128916/ --- (Updated Sept. 19, 2016, 6:14 p.m.) Review request for KDE Frameworks and

Re: Review Request 128916: kconfig: Make test XFAIL when running as root

> On Sept. 16, 2016, 4:57 p.m., Sune Vuorela wrote: > > autotests/kconfigtest.cpp, line 1376 > > > > > > Isn't a QSKIP if user is root in the beginning of the test a better > > approach ? > > Gleb Popov wrote:

Re: Review Request 128916: kconfig: Make test XFAIL when running as root

> On Sept. 16, 2016, 7:57 p.m., Sune Vuorela wrote: > > autotests/kconfigtest.cpp, line 1376 > > > > > > Isn't a QSKIP if user is root in the beginning of the test a better > > approach ? I think, XFAIL is bet

Re: Review Request 128916: kconfig: Make test XFAIL when running as root

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128916/#review99231 --- autotests/kconfigtest.cpp (line 1376)

Re: Review Request 128916: kconfig: Make test XFAIL when running as root

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128916/#review99227 --- I'd say ship it, but let's wait for someone else. - Gleb Pop

Re: Review Request 128916: kconfig: Make test XFAIL when running as root

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128916/ --- (Updated Sept. 16, 2016, 7:17 a.m.) Review request for KDE Frameworks and

Re: Review Request 128916: kconfig: Make test XFAIL when running as root

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128916/ --- (Updated Sept. 15, 2016, 8:49 p.m.) Review request for KDE Frameworks and

Re: Review Request 128916: kconfig: Make test XFAIL when running as root

> On Sept. 15, 2016, 3:01 p.m., Gleb Popov wrote: > > autotests/kconfigtest.cpp, line 1378 > > > > > > I'd put both `cgLocal.writeEntry("someLocalString", "whatever2");` and > > `QVERIFY(!cgLocal.sync());` insi

Re: Review Request 128916: kconfig: Make test XFAIL when running as root

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128916/#review99215 --- autotests/kconfigtest.cpp (line 1373)

Re: Review Request 128916: kconfig: Make test XFAIL when running as root

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128916/ --- (Updated Sept. 15, 2016, 1:20 p.m.) Review request for KDE Frameworks and

Re: Review Request 128916: kconfig: Make test XFAIL when running as root

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128916/#review99210 --- autotests/kconfigtest.cpp

Review Request 128916: kconfig: Make test XFAIL when running as root

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128916/ --- Review request for KDE Frameworks and Gleb Popov. Repository: kconfig D