Re: Review Request 129065: Fix frameworks compilation with Qt < 5.6
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129065/ --- (Updated Oct. 17, 2016, 3:46 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Plasma. Changes --- Submitted with commit f82d76eb2b915d5097f41a22a9f218e0bb23bb03 by David Edmundson on behalf of Alberto Curro to branch master. Repository: plasma-framework Description --- QQuickWindow::NoStage was new in Qt5.6. This uses a value that's valid in earlier Qt. This shouldn't have any behavioural effect. Diffs - src/declarativeimports/core/windowthumbnail.cpp 0453c092f7a7144f04fdacc81b031e8c352fa23b Diff: https://git.reviewboard.kde.org/r/129065/diff/ Testing --- Ran on my nvidia machine and moused over the taskbar. I got thumbnails as expected, but also Nvidia-settings shows "user dedicated memory" remaining constant Thanks, David Edmundson
Re: Review Request 129065: Fix frameworks compilation with Qt < 5.6
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129065/#review100087 --- Ship it! Ship It! - Marco Martin On Sept. 29, 2016, 11:50 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129065/ > --- > > (Updated Sept. 29, 2016, 11:50 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > --- > > QQuickWindow::NoStage was new in Qt5.6. This uses a value that's valid > in earlier Qt. > > This shouldn't have any behavioural effect. > > > Diffs > - > > src/declarativeimports/core/windowthumbnail.cpp > 0453c092f7a7144f04fdacc81b031e8c352fa23b > > Diff: https://git.reviewboard.kde.org/r/129065/diff/ > > > Testing > --- > > Ran on my nvidia machine and moused over the taskbar. > > I got thumbnails as expected, but also Nvidia-settings shows "user dedicated > memory" remaining constant > > > Thanks, > > David Edmundson > >
Re: Review Request 129065: Fix frameworks compilation with Qt < 5.6
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129065/ --- (Updated Sept. 29, 2016, 11:50 p.m.) Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- QQuickWindow::NoStage was new in Qt5.6. This uses a value that's valid in earlier Qt. This shouldn't have any behavioural effect. Diffs - src/declarativeimports/core/windowthumbnail.cpp 0453c092f7a7144f04fdacc81b031e8c352fa23b Diff: https://git.reviewboard.kde.org/r/129065/diff/ Testing (updated) --- Ran on my nvidia machine and moused over the taskbar. I got thumbnails as expected, but also Nvidia-settings shows "user dedicated memory" remaining constant Thanks, David Edmundson
Re: Review Request 129065: Fix frameworks compilation with Qt < 5.6
> On Sept. 29, 2016, 8:25 a.m., Marco Martin wrote: > > are you sure they are completely interchangeable? (would have to have an > > ifdef otherwise) they're not completely intechangable normally, but for this particular case it seems fine. I've just filled in the Testing Done propery. This runnable takes a copy of the pointers to some GL textures that should be deleted. the WindowThumbnail object then throws away its knowledge of those textures and at some point creates new ones. When the actual deletion of the old ones happens shouldn't affect WindowThumbnail at all. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129065/#review99654 --- On Sept. 28, 2016, 9:58 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129065/ > --- > > (Updated Sept. 28, 2016, 9:58 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > --- > > QQuickWindow::NoStage was new in Qt5.6. This uses a value that's valid > in earlier Qt. > > This shouldn't have any behavioural effect. > > > Diffs > - > > src/declarativeimports/core/windowthumbnail.cpp > 0453c092f7a7144f04fdacc81b031e8c352fa23b > > Diff: https://git.reviewboard.kde.org/r/129065/diff/ > > > Testing > --- > > > Thanks, > > David Edmundson > >
Re: Review Request 129065: Fix frameworks compilation with Qt < 5.6
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129065/#review99654 --- are you sure they are completely interchangeable? (would have to have an ifdef otherwise) - Marco Martin On Sept. 28, 2016, 9:58 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129065/ > --- > > (Updated Sept. 28, 2016, 9:58 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > --- > > QQuickWindow::NoStage was new in Qt5.6. This uses a value that's valid > in earlier Qt. > > This shouldn't have any behavioural effect. > > > Diffs > - > > src/declarativeimports/core/windowthumbnail.cpp > 0453c092f7a7144f04fdacc81b031e8c352fa23b > > Diff: https://git.reviewboard.kde.org/r/129065/diff/ > > > Testing > --- > > > Thanks, > > David Edmundson > >
Review Request 129065: Fix frameworks compilation with Qt < 5.6
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129065/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- QQuickWindow::NoStage was new in Qt5.6. This uses a value that's valid in earlier Qt. This shouldn't have any behavioural effect. Diffs - src/declarativeimports/core/windowthumbnail.cpp 0453c092f7a7144f04fdacc81b031e8c352fa23b Diff: https://git.reviewboard.kde.org/r/129065/diff/ Testing --- Thanks, David Edmundson
