Re: Review Request 129086: Update applet alternatives menu entry visibility on demand

2016-10-26 Thread Marco Martin
> On Oct. 26, 2016, 10:36 a.m., David Rosca wrote: > > This made the Alternatives action visible in toolbox menu. > > > > The problem is that toolbox tries to emit `contextualActionsAboutToShow` on > > `AppletInterface`, but the connection between > > `Applet::contextualActionsAboutToShow`

Re: Review Request 129086: Update applet alternatives menu entry visibility on demand

2016-10-26 Thread David Edmundson
> On Oct. 26, 2016, 10:36 a.m., David Rosca wrote: > > This made the Alternatives action visible in toolbox menu. > > > > The problem is that toolbox tries to emit `contextualActionsAboutToShow` on > > `AppletInterface`, but the connection between > > `Applet::contextualActionsAboutToShow`

Re: Review Request 129086: Update applet alternatives menu entry visibility on demand

2016-10-26 Thread David Rosca
> On Oct. 26, 2016, 10:36 a.m., David Rosca wrote: > > This made the Alternatives action visible in toolbox menu. > > > > The problem is that toolbox tries to emit `contextualActionsAboutToShow` on > > `AppletInterface`, but the connection between > > `Applet::contextualActionsAboutToShow`

Re: Review Request 129086: Update applet alternatives menu entry visibility on demand

2016-10-26 Thread David Edmundson
> On Oct. 26, 2016, 10:36 a.m., David Rosca wrote: > > This made the Alternatives action visible in toolbox menu. > > > > The problem is that toolbox tries to emit `contextualActionsAboutToShow` on > > `AppletInterface`, but the connection between > > `Applet::contextualActionsAboutToShow`

Re: Review Request 129086: Update applet alternatives menu entry visibility on demand

2016-10-26 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129086/#review100291 --- This made the Alternatives action visible in toolbox menu.

Re: Review Request 129086: Update applet alternatives menu entry visibility on demand

2016-10-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129086/ --- (Updated Oct. 3, 2016, 10:45 a.m.) Status -- This change has been

Re: Review Request 129086: Update applet alternatives menu entry visibility on demand

2016-10-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129086/#review99728 --- Ship it! very good point - Marco Martin On Oct. 3,

Review Request 129086: Update applet alternatives menu entry visibility on demand

2016-10-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129086/ --- Review request for KDE Frameworks and Plasma. Repository: