Re: Review Request 129122: Try to use ulog-helper if utempter does not exist

[Tobias Berner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129122/
---

(Updated Nov. 1, 2016, 9:42 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Adriaan de Groot, Gleb Popov, Oswald 
Buddenhagen, and Martin Tobias Holmedahl Sandsmark.


Changes
---

Submitted with commit 73c9dac629a59bb337168b47e0fd61975588b399 by Tobias C. 
Berner to branch master.


Repository: kpty


Description
---

FreeBSD does not have `/usr/libexec/*/utempter`. It does however have 
`/usr/libexec/ulog-helper` [1].

It uses `login` instead of `add` and `logout` instead of `del`.


[1] 
https://svnweb.freebsd.org/base/head/libexec/ulog-helper/ulog-helper.c?revision=234469=markup


Diffs
-

  cmake/FindUTEMPTER.cmake 4921e58 
  src/kpty.cpp 7bf31c3 

Diff: https://git.reviewboard.kde.org/r/129122/diff/


Testing
---

Builds fine. And it is actually working :)


Thanks,

Tobias Berner

Re: Review Request 129122: Try to use ulog-helper if utempter does not exist

[Oswald Buddenhagen]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129122/#review100380
---


Ship it!




if you want to push it already, make sure to omit the other commit for now.

- Oswald Buddenhagen


On Oct. 20, 2016, 7:52 a.m., Tobias Berner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129122/
> ---
> 
> (Updated Oct. 20, 2016, 7:52 a.m.)
> 
> 
> Review request for KDE Frameworks, Adriaan de Groot, Gleb Popov, Oswald 
> Buddenhagen, and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: kpty
> 
> 
> Description
> ---
> 
> FreeBSD does not have `/usr/libexec/*/utempter`. It does however have 
> `/usr/libexec/ulog-helper` [1].
> 
> It uses `login` instead of `add` and `logout` instead of `del`.
> 
> 
> [1] 
> https://svnweb.freebsd.org/base/head/libexec/ulog-helper/ulog-helper.c?revision=234469=markup
> 
> 
> Diffs
> -
> 
>   cmake/FindUTEMPTER.cmake 4921e58 
>   src/kpty.cpp 7bf31c3 
> 
> Diff: https://git.reviewboard.kde.org/r/129122/diff/
> 
> 
> Testing
> ---
> 
> Builds fine. And it is actually working :)
> 
> 
> Thanks,
> 
> Tobias Berner
> 
>

Re: Review Request 129122: Try to use ulog-helper if utempter does not exist

[Tobias Berner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129122/
---

(Updated Oct. 20, 2016, 7:52 a.m.)


Review request for KDE Frameworks, Adriaan de Groot, Gleb Popov, Oswald 
Buddenhagen, and Martin Tobias Holmedahl Sandsmark.


Repository: kpty


Description
---

FreeBSD does not have `/usr/libexec/*/utempter`. It does however have 
`/usr/libexec/ulog-helper` [1].

It uses `login` instead of `add` and `logout` instead of `del`.


[1] 
https://svnweb.freebsd.org/base/head/libexec/ulog-helper/ulog-helper.c?revision=234469=markup


Diffs
-

  cmake/FindUTEMPTER.cmake 4921e58 
  src/kpty.cpp 7bf31c3 

Diff: https://git.reviewboard.kde.org/r/129122/diff/


Testing (updated)
---

Builds fine. And it is actually working :)


Thanks,

Tobias Berner

Re: Review Request 129122: Try to use ulog-helper if utempter does not exist

[Tobias Berner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129122/
---

(Updated Oct. 20, 2016, 7:47 a.m.)


Review request for KDE Frameworks, Adriaan de Groot, Gleb Popov, Oswald 
Buddenhagen, and Martin Tobias Holmedahl Sandsmark.


Changes
---

fix identation (4spaces)


Repository: kpty


Description
---

FreeBSD does not have `/usr/libexec/*/utempter`. It does however have 
`/usr/libexec/ulog-helper` [1].

It uses `login` instead of `add` and `logout` instead of `del`.


[1] 
https://svnweb.freebsd.org/base/head/libexec/ulog-helper/ulog-helper.c?revision=234469=markup


Diffs (updated)
-

  cmake/FindUTEMPTER.cmake 4921e58 
  src/kpty.cpp 7bf31c3 

Diff: https://git.reviewboard.kde.org/r/129122/diff/


Testing
---

Builds fine. Still need to test if it is actually working.


Thanks,

Tobias Berner

Re: Review Request 129122: Try to use ulog-helper if utempter does not exist

[Gleb Popov]

> On Oct. 19, 2016, 11:07 p.m., Oswald Buddenhagen wrote:
> > an update about the runtime testing would be nice ;)

Here it is: https://git.reviewboard.kde.org/r/129197/

With this and that patch, the test passes on FreeBSD.


- Gleb


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129122/#review100144
---


On Oct. 19, 2016, 10:51 p.m., Tobias Berner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129122/
> ---
> 
> (Updated Oct. 19, 2016, 10:51 p.m.)
> 
> 
> Review request for KDE Frameworks, Adriaan de Groot, Gleb Popov, Oswald 
> Buddenhagen, and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: kpty
> 
> 
> Description
> ---
> 
> FreeBSD does not have `/usr/libexec/*/utempter`. It does however have 
> `/usr/libexec/ulog-helper` [1].
> 
> It uses `login` instead of `add` and `logout` instead of `del`.
> 
> 
> [1] 
> https://svnweb.freebsd.org/base/head/libexec/ulog-helper/ulog-helper.c?revision=234469=markup
> 
> 
> Diffs
> -
> 
>   cmake/FindUTEMPTER.cmake 4921e58 
>   src/kpty.cpp 7bf31c3 
> 
> Diff: https://git.reviewboard.kde.org/r/129122/diff/
> 
> 
> Testing
> ---
> 
> Builds fine. Still need to test if it is actually working.
> 
> 
> Thanks,
> 
> Tobias Berner
> 
>

Re: Review Request 129122: Try to use ulog-helper if utempter does not exist

[Oswald Buddenhagen]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129122/#review100144
---



an update about the runtime testing would be nice ;)


cmake/FindUTEMPTER.cmake (line 47)


just noticed: indentation wrong.


- Oswald Buddenhagen


On Oct. 19, 2016, 7:51 p.m., Tobias Berner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129122/
> ---
> 
> (Updated Oct. 19, 2016, 7:51 p.m.)
> 
> 
> Review request for KDE Frameworks, Adriaan de Groot, Gleb Popov, Oswald 
> Buddenhagen, and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: kpty
> 
> 
> Description
> ---
> 
> FreeBSD does not have `/usr/libexec/*/utempter`. It does however have 
> `/usr/libexec/ulog-helper` [1].
> 
> It uses `login` instead of `add` and `logout` instead of `del`.
> 
> 
> [1] 
> https://svnweb.freebsd.org/base/head/libexec/ulog-helper/ulog-helper.c?revision=234469=markup
> 
> 
> Diffs
> -
> 
>   cmake/FindUTEMPTER.cmake 4921e58 
>   src/kpty.cpp 7bf31c3 
> 
> Diff: https://git.reviewboard.kde.org/r/129122/diff/
> 
> 
> Testing
> ---
> 
> Builds fine. Still need to test if it is actually working.
> 
> 
> Thanks,
> 
> Tobias Berner
> 
>

Re: Review Request 129122: Try to use ulog-helper if utempter does not exist

[Tobias Berner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129122/
---

(Updated Oct. 19, 2016, 9:51 p.m.)


Review request for KDE Frameworks, Adriaan de Groot, Gleb Popov, Oswald 
Buddenhagen, and Martin Tobias Holmedahl Sandsmark.


Changes
---

switch from "#if !defined(UTEMPTER_ULOG)" to "#ifndef UTEMPTER_ULOG".


Repository: kpty


Description
---

FreeBSD does not have `/usr/libexec/*/utempter`. It does however have 
`/usr/libexec/ulog-helper` [1].

It uses `login` instead of `add` and `logout` instead of `del`.


[1] 
https://svnweb.freebsd.org/base/head/libexec/ulog-helper/ulog-helper.c?revision=234469=markup


Diffs (updated)
-

  cmake/FindUTEMPTER.cmake 4921e58 
  src/kpty.cpp 7bf31c3 

Diff: https://git.reviewboard.kde.org/r/129122/diff/


Testing
---

Builds fine. Still need to test if it is actually working.


Thanks,

Tobias Berner

Re: Review Request 129122: Try to use ulog-helper if utempter does not exist

[Oswald Buddenhagen]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129122/#review100127
---



doesn't look fundamentally wrong ^^


src/kpty.cpp (line 78)


no space after the !

or just use ifndef


- Oswald Buddenhagen


On Oct. 13, 2016, 2:08 p.m., Tobias Berner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129122/
> ---
> 
> (Updated Oct. 13, 2016, 2:08 p.m.)
> 
> 
> Review request for KDE Frameworks, Adriaan de Groot, Gleb Popov, Oswald 
> Buddenhagen, and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: kpty
> 
> 
> Description
> ---
> 
> FreeBSD does not have `/usr/libexec/*/utempter`. It does however have 
> `/usr/libexec/ulog-helper` [1].
> 
> It uses `login` instead of `add` and `logout` instead of `del`.
> 
> 
> [1] 
> https://svnweb.freebsd.org/base/head/libexec/ulog-helper/ulog-helper.c?revision=234469=markup
> 
> 
> Diffs
> -
> 
>   cmake/FindUTEMPTER.cmake 9773963 
>   src/kpty.cpp 7bf31c3 
> 
> Diff: https://git.reviewboard.kde.org/r/129122/diff/
> 
> 
> Testing
> ---
> 
> Builds fine. Still need to test if it is actually working.
> 
> 
> Thanks,
> 
> Tobias Berner
> 
>

Re: Review Request 129122: Try to use ulog-helper if utempter does not exist

[Tobias Berner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129122/
---

(Updated Oct. 9, 2016, 3:51 p.m.)


Review request for KDE Frameworks, Adriaan de Groot, Gleb Popov, and Martin 
Tobias Holmedahl Sandsmark.


Changes
---

Only define UTEMPTER_ULOG if we actually find ulog-helper


Repository: kpty


Description
---

FreeBSD does not have `/usr/libexec/*/utempter`. It does however have 
`/usr/libexec/ulog-helper` [1].

It uses `login` instead of `add` and `logout` instead of `del`.


[1] 
https://svnweb.freebsd.org/base/head/libexec/ulog-helper/ulog-helper.c?revision=234469=markup


Diffs (updated)
-

  cmake/FindUTEMPTER.cmake 9773963 
  src/kpty.cpp 7bf31c3 

Diff: https://git.reviewboard.kde.org/r/129122/diff/


Testing
---

Builds fine. Still need to test if it is actually working.


Thanks,

Tobias Berner

Re: Review Request 129122: Try to use ulog-helper if utempter does not exist

[Tobias Berner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129122/
---

(Updated Oct. 9, 2016, 3:49 p.m.)


Review request for KDE Frameworks, Adriaan de Groot, Gleb Popov, and Martin 
Tobias Holmedahl Sandsmark.


Changes
---

As Gleb suggested, only look in /usr/libexec for ulog-helper


Repository: kpty


Description
---

FreeBSD does not have `/usr/libexec/*/utempter`. It does however have 
`/usr/libexec/ulog-helper` [1].

It uses `login` instead of `add` and `logout` instead of `del`.


[1] 
https://svnweb.freebsd.org/base/head/libexec/ulog-helper/ulog-helper.c?revision=234469=markup


Diffs (updated)
-

  cmake/FindUTEMPTER.cmake 9773963 
  src/kpty.cpp 7bf31c3 

Diff: https://git.reviewboard.kde.org/r/129122/diff/


Testing
---

Builds fine. Still need to test if it is actually working.


Thanks,

Tobias Berner

Re: Review Request 129122: Try to use ulog-helper if utempter does not exist

[Gleb Popov]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129122/#review99871
---




cmake/FindUTEMPTER.cmake (line 45)


Why search in `KDE_INSTALL` folders? `ulog-helper` comes with base and 
should always be in `/usr/libexec`, no?


- Gleb Popov


On Oct. 8, 2016, 9:37 p.m., Tobias Berner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129122/
> ---
> 
> (Updated Oct. 8, 2016, 9:37 p.m.)
> 
> 
> Review request for KDE Frameworks, Adriaan de Groot, Gleb Popov, and Martin 
> Tobias Holmedahl Sandsmark.
> 
> 
> Repository: kpty
> 
> 
> Description
> ---
> 
> FreeBSD does not have `/usr/libexec/*/utempter`. It does however have 
> `/usr/libexec/ulog-helper` [1].
> 
> It uses `login` instead of `add` and `logout` instead of `del`.
> 
> 
> [1] 
> https://svnweb.freebsd.org/base/head/libexec/ulog-helper/ulog-helper.c?revision=234469=markup
> 
> 
> Diffs
> -
> 
>   cmake/FindUTEMPTER.cmake 9773963 
>   src/kpty.cpp 7bf31c3 
> 
> Diff: https://git.reviewboard.kde.org/r/129122/diff/
> 
> 
> Testing
> ---
> 
> Builds fine. Still need to test if it is actually working.
> 
> 
> Thanks,
> 
> Tobias Berner
> 
>

Re: Review Request 129122: Try to use ulog-helper if utempter does not exist

[Tobias Berner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129122/
---

(Updated Oct. 8, 2016, 8:37 p.m.)


Review request for KDE Frameworks, Adriaan de Groot, Gleb Popov, and Martin 
Tobias Holmedahl Sandsmark.


Changes
---

Apply the changes suggested by Adriaan.


Repository: kpty


Description
---

FreeBSD does not have `/usr/libexec/*/utempter`. It does however have 
`/usr/libexec/ulog-helper` [1].

It uses `login` instead of `add` and `logout` instead of `del`.


[1] 
https://svnweb.freebsd.org/base/head/libexec/ulog-helper/ulog-helper.c?revision=234469=markup


Diffs (updated)
-

  cmake/FindUTEMPTER.cmake 9773963 
  src/kpty.cpp 7bf31c3 

Diff: https://git.reviewboard.kde.org/r/129122/diff/


Testing
---

Builds fine. Still need to test if it is actually working.


Thanks,

Tobias Berner

Re: Review Request 129122: Try to use ulog-helper if utempter does not exist

[Adriaan de Groot]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129122/#review99857
---



Perhaps indent the CMake code? It is, after all, inside the body of an if()

How about moving the different command string literals to somewhere else (if 
this works stylistically)

#if ! defined(ULOG)
const char login_cmd[] = "add";
const char logout_cmd[] = "del";
#else
const char login_cmd[] = "login";
const char logout_cmd[] = "logout";
#endif

then in the actual code you only have one path, and use `QStringList() << 
QStringLiteral(appropriate_cmd)` as needed.

- Adriaan de Groot


On Oct. 8, 2016, 12:41 p.m., Tobias Berner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129122/
> ---
> 
> (Updated Oct. 8, 2016, 12:41 p.m.)
> 
> 
> Review request for KDE Frameworks, Adriaan de Groot, Gleb Popov, and Martin 
> Tobias Holmedahl Sandsmark.
> 
> 
> Repository: kpty
> 
> 
> Description
> ---
> 
> FreeBSD does not have `/usr/libexec/*/utempter`. It does however have 
> `/usr/libexec/ulog-helper` [1].
> 
> It uses `login` instead of `add` and `logout` instead of `del`.
> 
> 
> [1] 
> https://svnweb.freebsd.org/base/head/libexec/ulog-helper/ulog-helper.c?revision=234469=markup
> 
> 
> Diffs
> -
> 
>   cmake/FindUTEMPTER.cmake 9773963 
>   src/kpty.cpp 7bf31c3 
> 
> Diff: https://git.reviewboard.kde.org/r/129122/diff/
> 
> 
> Testing
> ---
> 
> Builds fine. Still need to test if it is actually working.
> 
> 
> Thanks,
> 
> Tobias Berner
> 
>

Re: Review Request 129122: Try to use ulog-helper if utempter does not exist

[Tobias Berner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129122/
---

(Updated Oct. 8, 2016, 2:41 p.m.)


Review request for KDE Frameworks, Adriaan de Groot, Gleb Popov, and Martin 
Tobias Holmedahl Sandsmark.


Summary (updated)
-

Try to use ulog-helper if utempter does not exist


Repository: kpty


Description
---

FreeBSD does not have `/usr/libexec/*/utempter`. It does however have 
`/usr/libexec/ulog-helper` [1].

It uses `login` instead of `add` and `logout` instead of `del`.


[1] 
https://svnweb.freebsd.org/base/head/libexec/ulog-helper/ulog-helper.c?revision=234469=markup


Diffs
-

  cmake/FindUTEMPTER.cmake 9773963 
  src/kpty.cpp 7bf31c3 

Diff: https://git.reviewboard.kde.org/r/129122/diff/


Testing
---

Builds fine. Still need to test if it is actually working.


Thanks,

Tobias Berner