Re: Review Request 129303: Fix include dir in pri file

2016-11-01 Thread David Rosca

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129303/
---

(Updated Nov. 1, 2016, 8:38 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Jan Grulich.


Changes
---

Submitted with commit 79725bf9892520538a6bde836ced583a65ea6767 by David Rosca 
to branch master.


Repository: modemmanager-qt


Description
---

Currently the pri file has Qt.ModemManagerQt.includes = 
/usr/include/ModemManagerQt.
This changes fixes it and makes it /usr/include/KF5/ModemManagerQt


Diffs
-

  src/CMakeLists.txt 29a7a63 

Diff: https://git.reviewboard.kde.org/r/129303/diff/


Testing
---

Correct include paths when used from qmake.


Thanks,

David Rosca



Re: Review Request 129303: Fix include dir in pri file

2016-11-01 Thread Jan Grulich

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129303/#review100460
---


Ship it!




Ship It!

- Jan Grulich


On Lis. 1, 2016, 8:21 dop., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129303/
> ---
> 
> (Updated Lis. 1, 2016, 8:21 dop.)
> 
> 
> Review request for KDE Frameworks and Jan Grulich.
> 
> 
> Repository: modemmanager-qt
> 
> 
> Description
> ---
> 
> Currently the pri file has Qt.ModemManagerQt.includes = 
> /usr/include/ModemManagerQt.
> This changes fixes it and makes it /usr/include/KF5/ModemManagerQt
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 29a7a63 
> 
> Diff: https://git.reviewboard.kde.org/r/129303/diff/
> 
> 
> Testing
> ---
> 
> Correct include paths when used from qmake.
> 
> 
> Thanks,
> 
> David Rosca
> 
>



Review Request 129303: Fix include dir in pri file

2016-11-01 Thread David Rosca

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129303/
---

Review request for KDE Frameworks and Jan Grulich.


Repository: modemmanager-qt


Description
---

Currently the pri file has Qt.ModemManagerQt.includes = 
/usr/include/ModemManagerQt.
This changes fixes it and makes it /usr/include/KF5/ModemManagerQt


Diffs
-

  src/CMakeLists.txt 29a7a63 

Diff: https://git.reviewboard.kde.org/r/129303/diff/


Testing
---

Correct include paths when used from qmake.


Thanks,

David Rosca