Re: Review Request 129706: Don't focus progress windows

[Martin Tobias Holmedahl Sandsmark]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129706/
---

(Updated Dec. 28, 2016, 7:51 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Albert Astals Cid, David Faure, and Martin 
Gräßlin.


Changes
---

Submitted with commit 16a449cddf7f63e62fc2f90c7fed4463e62f167d by Martin T. H. 
Sandsmark to branch master.


Bugs: 333934
https://bugs.kde.org/show_bug.cgi?id=333934


Repository: kjobwidgets


Description
---

Show the job tracking widget without stealing focus, e. g. from Kate
 when saving to FTP. This is especially important since there's a 0.5s
 delay before the window is shown so people often start interacting with
 the original window when the job progress is shown.


Diffs
-

  src/kwidgetjobtracker.cpp 585867a 

Diff: https://git.reviewboard.kde.org/r/129706/diff/


Testing
---

Job progress widgets don't steal focus anymore.


Thanks,

Martin Tobias Holmedahl Sandsmark

Re: Review Request 129706: Don't focus progress windows

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129706/#review101604
---


Ship it!




Ship It!

- Martin Gräßlin


On Dec. 27, 2016, 1:14 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129706/
> ---
> 
> (Updated Dec. 27, 2016, 1:14 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, David Faure, and Martin 
> Gräßlin.
> 
> 
> Bugs: 333934
> https://bugs.kde.org/show_bug.cgi?id=333934
> 
> 
> Repository: kjobwidgets
> 
> 
> Description
> ---
> 
> Show the job tracking widget without stealing focus, e. g. from Kate
>  when saving to FTP. This is especially important since there's a 0.5s
>  delay before the window is shown so people often start interacting with
>  the original window when the job progress is shown.
> 
> 
> Diffs
> -
> 
>   src/kwidgetjobtracker.cpp 585867a 
> 
> Diff: https://git.reviewboard.kde.org/r/129706/diff/
> 
> 
> Testing
> ---
> 
> Job progress widgets don't steal focus anymore.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

Re: Review Request 129706: Don't focus progress windows

[Martin Tobias Holmedahl Sandsmark]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129706/
---

(Updated Dec. 27, 2016, 12:14 p.m.)


Review request for KDE Frameworks, Albert Astals Cid, David Faure, and Martin 
Gräßlin.


Changes
---

actually update the diff, update description


Bugs: 333934
https://bugs.kde.org/show_bug.cgi?id=333934


Repository: kjobwidgets


Description (updated)
---

Show the job tracking widget without stealing focus, e. g. from Kate
 when saving to FTP. This is especially important since there's a 0.5s
 delay before the window is shown so people often start interacting with
 the original window when the job progress is shown.


Diffs (updated)
-

  src/kwidgetjobtracker.cpp 585867a 

Diff: https://git.reviewboard.kde.org/r/129706/diff/


Testing
---

Job progress widgets don't steal focus anymore.


Thanks,

Martin Tobias Holmedahl Sandsmark

Re: Review Request 129706: Don't focus progress windows

[Martin Tobias Holmedahl Sandsmark]

> On Dec. 26, 2016, 4:53 p.m., Martin Gräßlin wrote:
> > Use QWidget::setAttribute with Qt::WA_ShowWithoutActivating

doh, thanks! I was just looking at the window flags...


- Martin Tobias Holmedahl


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129706/#review101581
---


On Dec. 26, 2016, 3:15 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129706/
> ---
> 
> (Updated Dec. 26, 2016, 3:15 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, David Faure, and Martin 
> Gräßlin.
> 
> 
> Bugs: 333934
> https://bugs.kde.org/show_bug.cgi?id=333934
> 
> 
> Repository: kjobwidgets
> 
> 
> Description
> ---
> 
> If there is already a window with focus, re-set focus to that so we
>  don't steal focus. This is especially important since there's a 0.5s
>  delay before the window is shown so people often start interacting with
>  the original window when this is shown.
> 
> 
> Diffs
> -
> 
>   src/kwidgetjobtracker.cpp 585867a 
> 
> Diff: https://git.reviewboard.kde.org/r/129706/diff/
> 
> 
> Testing
> ---
> 
> Job progress widgets don't steal focus anymore.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

Re: Review Request 129706: Don't focus progress windows

[Martin Tobias Holmedahl Sandsmark]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129706/
---

(Updated Dec. 27, 2016, 12:13 p.m.)


Review request for KDE Frameworks, Albert Astals Cid, David Faure, and Martin 
Gräßlin.


Changes
---

use the WA_ShowWithoutActivating attribute recommended by Martin


Bugs: 333934
https://bugs.kde.org/show_bug.cgi?id=333934


Repository: kjobwidgets


Description
---

If there is already a window with focus, re-set focus to that so we
 don't steal focus. This is especially important since there's a 0.5s
 delay before the window is shown so people often start interacting with
 the original window when this is shown.


Diffs (updated)
-

  src/kwidgetjobtracker.cpp 585867a 

Diff: https://git.reviewboard.kde.org/r/129706/diff/


Testing
---

Job progress widgets don't steal focus anymore.


Thanks,

Martin Tobias Holmedahl Sandsmark

Re: Review Request 129706: Don't focus progress windows

[Martin Tobias Holmedahl Sandsmark]

> On Dec. 26, 2016, 4:24 p.m., Anthony Fieroni wrote:
> > src/kwidgetjobtracker.cpp, line 82
> > 
> >
> > You can try
> > vi->setWindowFlags(windowFlags() | Qt::WindowDoesNotAcceptFocus);
> > 
> > I didn't know there is input required widget ?

tried it, doesn't work with all WMs (i3 in particular).

in addition the window actually should be able to receive focus, it just 
shouldn't grab it immediately.


- Martin Tobias Holmedahl


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129706/#review101580
---


On Dec. 26, 2016, 3:15 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129706/
> ---
> 
> (Updated Dec. 26, 2016, 3:15 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, David Faure, and Martin 
> Gräßlin.
> 
> 
> Bugs: 333934
> https://bugs.kde.org/show_bug.cgi?id=333934
> 
> 
> Repository: kjobwidgets
> 
> 
> Description
> ---
> 
> If there is already a window with focus, re-set focus to that so we
>  don't steal focus. This is especially important since there's a 0.5s
>  delay before the window is shown so people often start interacting with
>  the original window when this is shown.
> 
> 
> Diffs
> -
> 
>   src/kwidgetjobtracker.cpp 585867a 
> 
> Diff: https://git.reviewboard.kde.org/r/129706/diff/
> 
> 
> Testing
> ---
> 
> Job progress widgets don't steal focus anymore.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

Re: Review Request 129706: Don't focus progress windows

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129706/#review101581
---



Use QWidget::setAttribute with Qt::WA_ShowWithoutActivating

- Martin Gräßlin


On Dec. 26, 2016, 4:15 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129706/
> ---
> 
> (Updated Dec. 26, 2016, 4:15 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, David Faure, and Martin 
> Gräßlin.
> 
> 
> Bugs: 333934
> https://bugs.kde.org/show_bug.cgi?id=333934
> 
> 
> Repository: kjobwidgets
> 
> 
> Description
> ---
> 
> If there is already a window with focus, re-set focus to that so we
>  don't steal focus. This is especially important since there's a 0.5s
>  delay before the window is shown so people often start interacting with
>  the original window when this is shown.
> 
> 
> Diffs
> -
> 
>   src/kwidgetjobtracker.cpp 585867a 
> 
> Diff: https://git.reviewboard.kde.org/r/129706/diff/
> 
> 
> Testing
> ---
> 
> Job progress widgets don't steal focus anymore.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

Re: Review Request 129706: Don't focus progress windows

[Anthony Fieroni]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129706/#review101580
---




src/kwidgetjobtracker.cpp (line 82)


You can try
vi->setWindowFlags(windowFlags() | Qt::WindowDoesNotAcceptFocus);

I didn't know there is input required widget ?


- Anthony Fieroni


On Дек. 26, 2016, 5:15 след обяд, Martin Tobias Holmedahl Sandsmark wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129706/
> ---
> 
> (Updated Дек. 26, 2016, 5:15 след обяд)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, David Faure, and Martin 
> Gräßlin.
> 
> 
> Bugs: 333934
> https://bugs.kde.org/show_bug.cgi?id=333934
> 
> 
> Repository: kjobwidgets
> 
> 
> Description
> ---
> 
> If there is already a window with focus, re-set focus to that so we
>  don't steal focus. This is especially important since there's a 0.5s
>  delay before the window is shown so people often start interacting with
>  the original window when this is shown.
> 
> 
> Diffs
> -
> 
>   src/kwidgetjobtracker.cpp 585867a 
> 
> Diff: https://git.reviewboard.kde.org/r/129706/diff/
> 
> 
> Testing
> ---
> 
> Job progress widgets don't steal focus anymore.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

Review Request 129706: Don't focus progress windows

[Martin Tobias Holmedahl Sandsmark]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129706/
---

Review request for KDE Frameworks, Albert Astals Cid and David Faure.


Bugs: 333934
https://bugs.kde.org/show_bug.cgi?id=333934


Repository: kjobwidgets


Description
---

If there is already a window with focus, re-set focus to that so we
 don't steal focus. This is especially important since there's a 0.5s
 delay before the window is shown so people often start interacting with
 the original window when this is shown.


Diffs
-

  src/kwidgetjobtracker.cpp 585867a 

Diff: https://git.reviewboard.kde.org/r/129706/diff/


Testing
---

Job progress widgets don't steal focus anymore.


Thanks,

Martin Tobias Holmedahl Sandsmark