Re: Review Request 129985: [kio-extras] Thumbs for audio files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129985/ --- (Updated March 11, 2017, 6:07 a.m.) Status -- This change has been

Re: Review Request 129985: [kio-extras] Thumbs for audio files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129985/ --- (Updated March 10, 2017, 1:26 p.m.) Review request for KDE Frameworks,

Re: Review Request 129985: [kio-extras] Thumbs for audio files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129985/#review102779 --- Fix it, then Ship it! Looks good to me now.

Re: Review Request 129985: [kio-extras] Thumbs for audio files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129985/#review102777 --- Any other downsides? - Anthony Fieroni On Март 6, 2017,

Re: Review Request 129985: [kio-extras] Thumbs for audio files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129985/ --- (Updated Март 6, 2017, 7:44 преди обяд) Review request for KDE

Re: Review Request 129985: [kio-extras] Thumbs for audio files

> On March 5, 2017, 5:58 p.m., David Faure wrote: > > Heh KDE3 is back (we had such functionality long ago). > > > > No objection about the feature itself, but can it be off by default? I hate > > computers that make noise^H^Hsounds unexpectedly. Can be very embarrassing > > when it happens

Re: Review Request 129985: [kio-extras] Thumbs for audio files

> On March 5, 2017, 5:58 p.m., David Faure wrote: > > Heh KDE3 is back (we had such functionality long ago). > > > > No objection about the feature itself, but can it be off by default? I hate > > computers that make noise^H^Hsounds unexpectedly. Can be very embarrassing > > when it happens

Re: Review Request 129985: [kio-extras] Thumbs for audio files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129985/#review102722 --- Heh KDE3 is back (we had such functionality long ago). No

Re: Review Request 129985: [kio-extras] Thumbs for audio files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129985/ --- (Updated Март 5, 2017, 7:51 след обяд) Review request for KDE

Re: Review Request 129985: [kio-extras] Thumbs for audio files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129985/#review102721 --- thumbnail/audiocreator.cpp (line 213)

Re: Review Request 129985: [kio-extras] Thumbs for audio files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129985/ --- (Updated Март 5, 2017, 5:02 след обяд) Review request for KDE

Re: Review Request 129985: [kio-extras] Thumbs for audio files

> On Март 5, 2017, 4 след обяд, Elvis Angelaccio wrote: > > thumbnail/CMakeLists.txt, lines 241-243 > > > > > > This does not work, if you need to do: > > > > ``` > > if (TAGLIB_FOUND) > >

Re: Review Request 129985: [kio-extras] Thumbs for audio files

> On March 5, 2017, 2 p.m., Elvis Angelaccio wrote: > > thumbnail/CMakeLists.txt, lines 241-243 > > > > > > This does not work, if you need to do: > > > > ``` > > if (TAGLIB_FOUND) > >

Re: Review Request 129985: [kio-extras] Thumbs for audio files

> On Март 5, 2017, 4 след обяд, Elvis Angelaccio wrote: > > thumbnail/CMakeLists.txt, lines 241-243 > > > > > > This does not work, if you need to do: > > > > ``` > > if (TAGLIB_FOUND) > >

Re: Review Request 129985: [kio-extras] Thumbs for audio files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129985/#review102717 --- thumbnail/CMakeLists.txt (line 217)

Re: Review Request 129985: [kio-extras] Thumbs for audio files

> On March 5, 2017, 11:54 a.m., Kai Uwe Broulik wrote: > > This superseds Review 127281? Yes, this one supports more formats - Elvis --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 129985: [kio-extras] Thumbs for audio files

> On March 5, 2017, 10:21 a.m., Elvis Angelaccio wrote: > > thumbnail/audiothumbs.desktop, line 7 > > > > > > Not sure if wildcards are allowed by the .desktop specification. @David > > are they? > > Anthony

Re: Review Request 129985: [kio-extras] Thumbs for audio files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129985/#review102713 --- This superseds Review 127281? - Kai Uwe Broulik On März

Re: Review Request 129985: [kio-extras] Thumbs for audio files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129985/ --- (Updated Март 5, 2017, 1:27 след обяд) Review request for KDE

Re: Review Request 129985: [kio-extras] Thumbs for audio files

> On Март 5, 2017, 12:21 след обяд, Elvis Angelaccio wrote: > > thumbnail/audiothumbs.desktop, line 7 > > > > > > Not sure if wildcards are allowed by the .desktop specification. @David > > are they? It should

Re: Review Request 129985: [kio-extras] Thumbs for audio files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129985/#review102711 --- +1 I've been using it for a while and works fine (from

Review Request 129985: [kio-extras] Thumbs for audio files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129985/ --- Review request for KDE Frameworks, David Faure and Elvis Angelaccio.