Re: Review Request 129986: KUrlRequester does not allow proper save filedialog

[Jean-Baptiste Mardelle]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129986/
---

(Updated March 5, 2017, 9:04 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Changes
---

Submitted with commit 143fbd2cd9d5698420ec246f03a4aea24d9d33b3 by Jean-Baptiste 
Mardelle to branch master.


Bugs: 371685
https://bugs.kde.org/show_bug.cgi?id=371685


Repository: kio


Description
---

Using a KUrlRequester to select a file to save is not currently working. The 
file dialog is always opening in "open" mode, never in "save" mode. My patch 
adds a method to call setAcceptMode on the file dialog. Some users reported 
that the current behavior completely breaks the functionnality on some 
platforms(Gnome), making it impossible to select a non existing file.


Diffs
-

  src/widgets/kurlrequester.h 51c1259 
  src/widgets/kurlrequester.cpp 62e1fea 

Diff: https://git.reviewboard.kde.org/r/129986/diff/


Testing
---

Tested locally, the dialog opening from the KUrlRequester is now a proper 
"save" dialog


Thanks,

Jean-Baptiste Mardelle

Re: Review Request 129986: KUrlRequester does not allow proper save filedialog

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129986/#review102728
---


Ship it!




Ship It!

- David Faure


On March 5, 2017, 8 p.m., Jean-Baptiste Mardelle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129986/
> ---
> 
> (Updated March 5, 2017, 8 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 371685
> https://bugs.kde.org/show_bug.cgi?id=371685
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Using a KUrlRequester to select a file to save is not currently working. The 
> file dialog is always opening in "open" mode, never in "save" mode. My patch 
> adds a method to call setAcceptMode on the file dialog. Some users reported 
> that the current behavior completely breaks the functionnality on some 
> platforms(Gnome), making it impossible to select a non existing file.
> 
> 
> Diffs
> -
> 
>   src/widgets/kurlrequester.h 51c1259 
>   src/widgets/kurlrequester.cpp 62e1fea 
> 
> Diff: https://git.reviewboard.kde.org/r/129986/diff/
> 
> 
> Testing
> ---
> 
> Tested locally, the dialog opening from the KUrlRequester is now a proper 
> "save" dialog
> 
> 
> Thanks,
> 
> Jean-Baptiste Mardelle
> 
>

Re: Review Request 129986: KUrlRequester does not allow proper save filedialog

[Jean-Baptiste Mardelle]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129986/
---

(Updated March 5, 2017, 8 p.m.)


Review request for KDE Frameworks and David Faure.


Changes
---

Added @since 5.33, make applyFileMode static


Bugs: 371685
https://bugs.kde.org/show_bug.cgi?id=371685


Repository: kio


Description
---

Using a KUrlRequester to select a file to save is not currently working. The 
file dialog is always opening in "open" mode, never in "save" mode. My patch 
adds a method to call setAcceptMode on the file dialog. Some users reported 
that the current behavior completely breaks the functionnality on some 
platforms(Gnome), making it impossible to select a non existing file.


Diffs (updated)
-

  src/widgets/kurlrequester.h 51c1259 
  src/widgets/kurlrequester.cpp 62e1fea 

Diff: https://git.reviewboard.kde.org/r/129986/diff/


Testing
---

Tested locally, the dialog opening from the KUrlRequester is now a proper 
"save" dialog


Thanks,

Jean-Baptiste Mardelle

Re: Review Request 129986: KUrlRequester does not allow proper save filedialog

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129986/#review102727
---




src/widgets/kurlrequester.h (line 133)


@since 5.33



src/widgets/kurlrequester.h (line 139)


@since 5.33



src/widgets/kurlrequester.cpp (line 199)


I wonder why this method doesn't use the member variables rather than 
taking them all as arguments...

Make the method static, while you're here? It will make more sense then.


- David Faure


On March 5, 2017, 7:46 p.m., Jean-Baptiste Mardelle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129986/
> ---
> 
> (Updated March 5, 2017, 7:46 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 371685
> https://bugs.kde.org/show_bug.cgi?id=371685
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Using a KUrlRequester to select a file to save is not currently working. The 
> file dialog is always opening in "open" mode, never in "save" mode. My patch 
> adds a method to call setAcceptMode on the file dialog. Some users reported 
> that the current behavior completely breaks the functionnality on some 
> platforms(Gnome), making it impossible to select a non existing file.
> 
> 
> Diffs
> -
> 
>   src/widgets/kurlrequester.h 51c1259 
>   src/widgets/kurlrequester.cpp 62e1fea 
> 
> Diff: https://git.reviewboard.kde.org/r/129986/diff/
> 
> 
> Testing
> ---
> 
> Tested locally, the dialog opening from the KUrlRequester is now a proper 
> "save" dialog
> 
> 
> Thanks,
> 
> Jean-Baptiste Mardelle
> 
>

Review Request 129986: KUrlRequester does not allow proper save filedialog

[Jean-Baptiste Mardelle]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129986/
---

Review request for KDE Frameworks and David Faure.


Bugs: 371685
https://bugs.kde.org/show_bug.cgi?id=371685


Repository: kio


Description
---

Using a KUrlRequester to select a file to save is not currently working. The 
file dialog is always opening in "open" mode, never in "save" mode. My patch 
adds a method to call setAcceptMode on the file dialog. Some users reported 
that the current behavior completely breaks the functionnality on some 
platforms(Gnome), making it impossible to select a non existing file.


Diffs
-

  src/widgets/kurlrequester.h 51c1259 
  src/widgets/kurlrequester.cpp 62e1fea 

Diff: https://git.reviewboard.kde.org/r/129986/diff/


Testing
---

Tested locally, the dialog opening from the KUrlRequester is now a proper 
"save" dialog


Thanks,

Jean-Baptiste Mardelle