Re: Retirement of Reviewboard - Transition to Phabricator
On 25/08/2017 5:41 AM, "Albert Astals Cid" <aa...@kde.org> wrote: El dijous, 24 d’agost de 2017, a les 21:07:49 CEST, Ben Cooksley va escriure: > Hi all, > > The following is Sysadmin's suggested plan for the retirement of > Reviewboard now that Phabricator is fully up and running for hosting > of code reviews. > > Phase 1: Commences September 2: All repositories are closed for > accepting new reviews on Reviewboard. A notice is added to the top of > the main page indicating that reviews should now be done on > Phabricator. > > Phase 2: Commences September 16: Login to Reviewboard is disabled, and > final backups are taken. A static copy of Reviewboard is generated and > published online, and the software itself is taken down. Does this mean i can still see: * Diffs * emails of the people that made those diffs Diffs should definitely be - as long as they're not broken due to the issue I noted. As you wouldn't be able to access them currently there is no change in that regard. In terms of email addresses this will only be the case if Reviewboard displays them publicly. Their username will still be shown though which we can lookup on Identity. Regards, Ben After phase 2? Cheers, Albert > > The vast majority of projects should now be migrated to Phabricator, > with only historical reviews needing to be cleaned up. > > Note that due to how Reviewboard stores diffs and reproduces them for > use, some reviews may have decayed and may no longer be readable. This > is due to short-hashes which are used by Git/Reviewboard in diffs now > having collisions with other commits which previously did not exist. > Unfortunately there is nothing we can do about this. > > Any comments on the above? > > Regards, > Ben
Re: Retirement of Reviewboard - Transition to Phabricator
On Mon, Aug 28, 2017 at 8:20 PM, René J.V. Bertin <rjvber...@gmail.com> wrote: > On Friday August 25 2017 07:33:43 Ben Cooksley wrote: > > Hi, Hi Rene, > >>> Note that due to how Reviewboard stores diffs and reproduces them for >>> use, some reviews may have decayed and may no longer be readable. This >>> is due to short-hashes which are used by Git/Reviewboard in diffs now >>> having collisions with other commits which previously did not exist. >>> Unfortunately there is nothing we can do about this. > > This is probably a "wild thought", but would it be possible somehow to limit > the issue by not letting the ReviewBoard software compare to each repo's HEAD > but against whatever commit is current now (or when you retire the thing)? Reviewboard to my knowledge compares against the commit sha's mentioned in the diff. > > And FWIW, you're aware of git-diff's --full-index option? ;) This is something the contributor could have done when uploading yes, but isn't something we can do anything about now. > > R. Regards, Ben
Re: Retirement of Reviewboard - Transition to Phabricator
On Friday August 25 2017 07:33:43 Ben Cooksley wrote: Hi, >> Note that due to how Reviewboard stores diffs and reproduces them for >> use, some reviews may have decayed and may no longer be readable. This >> is due to short-hashes which are used by Git/Reviewboard in diffs now >> having collisions with other commits which previously did not exist. >> Unfortunately there is nothing we can do about this. This is probably a "wild thought", but would it be possible somehow to limit the issue by not letting the ReviewBoard software compare to each repo's HEAD but against whatever commit is current now (or when you retire the thing)? And FWIW, you're aware of git-diff's --full-index option? ;) R.
Re: Retirement of Reviewboard - Transition to Phabricator
El dijous, 24 d’agost de 2017, a les 21:07:49 CEST, Ben Cooksley va escriure: > Hi all, > > The following is Sysadmin's suggested plan for the retirement of > Reviewboard now that Phabricator is fully up and running for hosting > of code reviews. > > Phase 1: Commences September 2: All repositories are closed for > accepting new reviews on Reviewboard. A notice is added to the top of > the main page indicating that reviews should now be done on > Phabricator. > > Phase 2: Commences September 16: Login to Reviewboard is disabled, and > final backups are taken. A static copy of Reviewboard is generated and > published online, and the software itself is taken down. Does this mean i can still see: * Diffs * emails of the people that made those diffs After phase 2? Cheers, Albert > > The vast majority of projects should now be migrated to Phabricator, > with only historical reviews needing to be cleaned up. > > Note that due to how Reviewboard stores diffs and reproduces them for > use, some reviews may have decayed and may no longer be readable. This > is due to short-hashes which are used by Git/Reviewboard in diffs now > having collisions with other commits which previously did not exist. > Unfortunately there is nothing we can do about this. > > Any comments on the above? > > Regards, > Ben
Retirement of Reviewboard - Transition to Phabricator
Hi all, The following is Sysadmin's suggested plan for the retirement of Reviewboard now that Phabricator is fully up and running for hosting of code reviews. Phase 1: Commences September 2: All repositories are closed for accepting new reviews on Reviewboard. A notice is added to the top of the main page indicating that reviews should now be done on Phabricator. Phase 2: Commences September 16: Login to Reviewboard is disabled, and final backups are taken. A static copy of Reviewboard is generated and published online, and the software itself is taken down. The vast majority of projects should now be migrated to Phabricator, with only historical reviews needing to be cleaned up. Note that due to how Reviewboard stores diffs and reproduces them for use, some reviews may have decayed and may no longer be readable. This is due to short-hashes which are used by Git/Reviewboard in diffs now having collisions with other commits which previously did not exist. Unfortunately there is nothing we can do about this. Any comments on the above? Regards, Ben
Re: Review Request 129154: reviewboard-am: add marker to ignore following text
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129154/ --- (Updated Oct. 12, 2016, 5:17 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Aurélien Gâteau. Changes --- Submitted with commit 6221fbec096fc31a16a8f644714342e7c52d3216 by Peter Wu to branch master. Repository: kde-dev-scripts Description --- Raw patches from reviewboard can contain additional text, ignore these in favor of the commit message based on the description. Diffs - reviewboard-am e96c9a91c8e9186f8a24a03c551936f93a41d4e2 Diff: https://git.reviewboard.kde.org/r/129154/diff/ Testing --- Tested with https://git.reviewboard.kde.org/r/129137/ which somehow has retained the text in the diff: https://git.reviewboard.kde.org/r/129137/diff/raw/ Thanks, Peter Wu
Re: Review Request 129155: reviewboard-am: add Python 3 compatibility
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129155/ --- (Updated Oct. 12, 2016, 8:17 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Aurélien Gâteau. Changes --- Submitted with commit a19ca72213586a05d6aff67c6562b3c60c5b012f by Peter Wu to branch master. Repository: kde-dev-scripts Description --- Tested with Python 2.7.12 and 3.5.2. Diffs - reviewboard-am e96c9a91c8e9186f8a24a03c551936f93a41d4e2 Diff: https://git.reviewboard.kde.org/r/129155/diff/ Testing --- (Note: changes the same context as review 129154.) Thanks, Peter Wu
Re: Review Request 129154: reviewboard-am: add marker to ignore following text
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129154/#review99952 --- Ship it! Ship It! - David Edmundson On Oct. 11, 2016, 8:29 p.m., Peter Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129154/ > --- > > (Updated Oct. 11, 2016, 8:29 p.m.) > > > Review request for KDE Frameworks and Aurélien Gâteau. > > > Repository: kde-dev-scripts > > > Description > --- > > Raw patches from reviewboard can contain additional text, ignore these > in favor of the commit message based on the description. > > > Diffs > - > > reviewboard-am e96c9a91c8e9186f8a24a03c551936f93a41d4e2 > > Diff: https://git.reviewboard.kde.org/r/129154/diff/ > > > Testing > --- > > Tested with https://git.reviewboard.kde.org/r/129137/ which somehow has > retained the text in the diff: > https://git.reviewboard.kde.org/r/129137/diff/raw/ > > > Thanks, > > Peter Wu > >
Re: Review Request 129155: reviewboard-am: add Python 3 compatibility
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129155/#review99951 --- Ship it! Ship It! - David Edmundson On Oct. 11, 2016, 8:36 p.m., Peter Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129155/ > --- > > (Updated Oct. 11, 2016, 8:36 p.m.) > > > Review request for KDE Frameworks and Aurélien Gâteau. > > > Repository: kde-dev-scripts > > > Description > --- > > Tested with Python 2.7.12 and 3.5.2. > > > Diffs > - > > reviewboard-am e96c9a91c8e9186f8a24a03c551936f93a41d4e2 > > Diff: https://git.reviewboard.kde.org/r/129155/diff/ > > > Testing > --- > > (Note: changes the same context as review 129154.) > > > Thanks, > > Peter Wu > >
Review Request 129155: reviewboard-am: add Python 3 compatibility
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129155/ --- Review request for KDE Frameworks. Repository: kde-dev-scripts Description --- Tested with Python 2.7.12 and 3.5.2. Diffs - reviewboard-am e96c9a91c8e9186f8a24a03c551936f93a41d4e2 Diff: https://git.reviewboard.kde.org/r/129155/diff/ Testing --- (Note: changes the same context as review 129154.) Thanks, Peter Wu
Review Request 129154: reviewboard-am: add marker to ignore following text
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129154/ --- Review request for KDE Frameworks and Aurélien Gâteau. Repository: kde-dev-scripts Description --- Raw patches from reviewboard can contain additional text, ignore these in favor of the commit message based on the description. Diffs - reviewboard-am e96c9a91c8e9186f8a24a03c551936f93a41d4e2 Diff: https://git.reviewboard.kde.org/r/129154/diff/ Testing --- Tested with https://git.reviewboard.kde.org/r/129137/ which somehow has retained the text in the diff: https://git.reviewboard.kde.org/r/129137/diff/raw/ Thanks, Peter Wu
Re: Review Request 116540: Add configuration for ReviewBoard
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116540/ --- (Updated March 3, 2014, 9:46 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: krunner Description --- Add configuration for ReviewBoard Diffs - .reviewboardrc PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116540/diff/ Testing --- Thanks, Cornelius Schumacher ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116540: Add configuration for ReviewBoard
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116540/#review51731 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 2, 2014, 8:10 p.m., Cornelius Schumacher wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116540/ --- (Updated March 2, 2014, 8:10 p.m.) Review request for KDE Frameworks. Repository: krunner Description --- Add configuration for ReviewBoard Diffs - .reviewboardrc PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116540/diff/ Testing --- Thanks, Cornelius Schumacher ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Reviewboard and maintainers
Just a note that if you are the maintainer of a framework, you may want to add the following line to the .reviewboardrc file of the git repo: TARGET_PEOPLE = 'kde_username' For example, I would put TARGET_PEOPLE = 'alexmerry' This means that you get CC'd on every review request posted using RBTools; currently, it just goes to the kdeframeworks group. Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Frameworks repositories on reviewboard
Hello all, Everything is in the subject of this email. Thanks to Ben for doing the grunt work as usual. Ben you rock! So now people can report bugs on bugzilla and can send us patches through reviewboard. Cheers! -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
reviewboard repository
Hi there, I was trying to post a patch for kparts today, but failed to find a kparts repository in reviewboard. So, what is the current way of submitting patch to any of frameworks libs? Cheers Michal ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: reviewboard repository
On 24/12/13 09:57, Michal Humpula wrote: Hi there, I was trying to post a patch for kparts today, but failed to find a kparts repository in reviewboard. So, what is the current way of submitting patch to any of frameworks libs? Patch attached to an email to this list. However, we're currently concentrating on getting the tech preview out the door (and it's Christmas) so you may find you don't get much response for now. Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Reviewboard
I tried adding frameworks group to the last review I posted for the cleanup task I just finished, but rb said there's no such group... Jeremy On Fri, Jul 20, 2012 at 10:04 AM, David Faure fa...@kde.org wrote: There is now a frameworks group on reviewboard, which you can use so that reviews are sent to this list. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
