Re: Splitting KWayland
That is what I imagined. The protocols section contains some things we can strip down. We shouldn't host anything that's in wayland-protocols like text-input. Also I think there's some dead things like plasma-effects. But we can do that sort of thing anytime before the first release. David
Re: Splitting KWayland
On Mon, Apr 27, 2020 at 2:57 PM Aleix Pol wrote: > > Hi, > As discussed in the meeting last week, I've been looking into the split. > > Here's what I was thinking of, please tell me if there's something > massively important I'm missing. > > The idea would be to start working on it after kwayland and other kf5 > have been tagged next week (?). > > Something I was wondering too is that I guess the new repos should end > up in invent? Although neither plasma or kf5 are there. > So maybe not? > > There's a couple of questions below as well, thoughts would be welcome > > Aleix > > git clone kde:kwayland > mv kwayland plasma-wayland-protocols > cd plasma-wayland-protocols > git rm -r autotests/ docs/ tests/ src/ > # fix build > # close https://phabricator.kde.org/T13024 > > git clone kde:kwayland > mv kwayland/ kwayland-server > git rm -r src/client/ > # namespace KWayland::Server -> namespace KWaylandServer > # fix build > # remove server tests? > # see to move things to KWin? > # close https://phabricator.kde.org/T13025 > > git clone kde:kwayland > # deprecate all KWayland::Server > # remove server tests? Here's an implementation of above: https://invent.kde.org/apol/plasma-wayland-protocols https://invent.kde.org/apol/kwayland-server My suggestion as next steps is to turn these into proper KDE repositories in its own right soon and develop master kwin and plasma overall against these. When 5.19 needs releasing, then the wayland protocol would be included in KF5. Can someone take a look and tell me if it's what they expected? If so I'll proceed to request the repositories and start talking to the different stakeholders. Aleix
Re: Splitting KWayland
On Tue, 28 Apr 2020, 07:24 Vlad Zahorodnii, wrote: > On 4/27/20 4:12 PM, David Edmundson wrote: > > I don't think we want to remove client or server tests on this one. As > > the client tests covered the server side too > > Hmm, does this mean we are going to keep both the client and the server > side in KWaylandServer? > No. We said we would build them against KWayland::Client With the slow migration for the protocols to be against the new approach. David > > Cheers, > Vlad > > >
Re: Splitting KWayland
On 4/27/20 4:12 PM, David Edmundson wrote: I don't think we want to remove client or server tests on this one. As the client tests covered the server side too Hmm, does this mean we are going to keep both the client and the server side in KWaylandServer? Cheers, Vlad
Re: Splitting KWayland
On Mon, Apr 27, 2020 at 2:12 PM David Edmundson wrote: > > > On Mon, Apr 27, 2020 at 1:58 PM Aleix Pol wrote: > >> Hi, >> As discussed in the meeting last week, I've been looking into the split. >> >> Here's what I was thinking of, please tell me if there's something >> massively important I'm missing. >> >> The idea would be to start working on it after kwayland and other kf5 >> have been tagged next week (?). >> >> Something I was wondering too is that I guess the new repos should end >> up in invent? Although neither plasma or kf5 are there. >> So maybe not? >> > > Given the recent gitlab status update from bshah, that'll be happening > soon. > >> >> There's a couple of questions below as well, thoughts would be welcome >> >> Aleix >> >> git clone kde:kwayland >> mv kwayland plasma-wayland-protocols >> cd plasma-wayland-protocols >> git rm -r autotests/ docs/ tests/ src/ >> # fix build >> # close https://phabricator.kde.org/T13024 > > > And changing it so we install the KDE specific protocol files > > >> git clone kde:kwayland >> mv kwayland/ kwayland-server >> > > git rm -r src/client/ >> # namespace KWayland::Server -> namespace KWaylandServer >> # fix build >> # remove server tests? >> > > I don't think we want to remove client or server tests on this one. As the > client tests covered the server side too > Even if it does mean some short-term duplication. > > >> # see to move things to KWin? >> > > I don't know which things you were referring to, but I'd suggest we keep > things simple. > >> >> # close https://phabricator.kde.org/T13025 > > > > >> git clone kde:kwayland >> > > git rm src/client/protocols and use the installed ones from the first repo > > >> # deprecate all KWayland::Server > > > We need a big README in the src/server. IMO it's not worth the hassle of > changing the header files. > > # remove server tests? >> > Yeah, can do. > > > > > >
Re: Splitting KWayland
On Mon, Apr 27, 2020 at 1:58 PM Aleix Pol wrote: > Hi, > As discussed in the meeting last week, I've been looking into the split. > > Here's what I was thinking of, please tell me if there's something > massively important I'm missing. > > The idea would be to start working on it after kwayland and other kf5 > have been tagged next week (?). > > Something I was wondering too is that I guess the new repos should end > up in invent? Although neither plasma or kf5 are there. > So maybe not? > Given the recent gitlab status update from bshah, that'll be happening soon. > > There's a couple of questions below as well, thoughts would be welcome > > Aleix > > git clone kde:kwayland > mv kwayland plasma-wayland-protocols > cd plasma-wayland-protocols > git rm -r autotests/ docs/ tests/ src/ > # fix build > # close https://phabricator.kde.org/T13024 And changing it so we install the KDE specific protocol files > git clone kde:kwayland > mv kwayland/ kwayland-server > git rm -r src/client/ > # namespace KWayland::Server -> namespace KWaylandServer > # fix build > # remove server tests? > I don't think we want to remove client or server tests on this one. As the client tests covered the server side too Even if it does mean some short-term duplication. > # see to move things to KWin? > I don't know which things you were referring to, but I'd suggest we keep things simple. > > # close https://phabricator.kde.org/T13025 > git clone kde:kwayland > git rm src/client/protocols and use the installed ones from the first repo > # deprecate all KWayland::Server We need a big README in the src/server. IMO it's not worth the hassle of changing the header files. # remove server tests? > Yeah, can do.
Splitting KWayland
Hi, As discussed in the meeting last week, I've been looking into the split. Here's what I was thinking of, please tell me if there's something massively important I'm missing. The idea would be to start working on it after kwayland and other kf5 have been tagged next week (?). Something I was wondering too is that I guess the new repos should end up in invent? Although neither plasma or kf5 are there. So maybe not? There's a couple of questions below as well, thoughts would be welcome Aleix git clone kde:kwayland mv kwayland plasma-wayland-protocols cd plasma-wayland-protocols git rm -r autotests/ docs/ tests/ src/ # fix build # close https://phabricator.kde.org/T13024 git clone kde:kwayland mv kwayland/ kwayland-server git rm -r src/client/ # namespace KWayland::Server -> namespace KWaylandServer # fix build # remove server tests? # see to move things to KWin? # close https://phabricator.kde.org/T13025 git clone kde:kwayland # deprecate all KWayland::Server # remove server tests?
